Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2692473003:
Modify HTMLLabelElement::control to check if label is in tree scope (Closed)
DescriptionModify HTMLLabelElement::control to check if label is in tree scope
HTMLLabelElement.control should not return the input element if <label> and <input> are in different trees.
New behavior matches to the specification as per:
https://html.spec.whatwg.org/#labeled-control
BUG=683461
Review-Url: https://codereview.chromium.org/2692473003
Cr-Commit-Position: refs/heads/master@{#449855}
Committed: https://chromium.googlesource.com/chromium/src/+/b0d6dc9fc0c9ad8b4944fa48125ad5bcf3f29146
Patch Set 1 #
Messages
Total messages: 28 (20 generated)
Description was changed from ========== Modify HTMLLabelElement::control to check if label is in tree scope HTMLLabelElement.control should not return the input element if <label> and <input> are in different trees. New behavior matches to the specification as per: https://html.spec.whatwg.org/#labeled-control BUG=683461 ========== to ========== Modify HTMLLabelElement::control to check if label is in tree scope HTMLLabelElement.control should not return the input element if <label> and <input> are in different trees. New behavior matches to the specification as per: https://html.spec.whatwg.org/#labeled-control BUG=683461 ==========
matthieu.rigolot@gmail.com changed reviewers: + thakis@chromium.org, tkent@chromium.org
matthieu.rigolot@gmail.com changed required reviewers: + thakis@chromium.org, tkent@chromium.org
The CQ bit was checked by matthieu.rigolot@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
matthieu.rigolot@gmail.com changed reviewers: + matthieu.rigolot@gmail.com - Matthieu.Rigolot@gmail.com
Hi, PTAL.
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by tkent@chromium.org
The CQ bit was checked by tkent@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
tkent@chromium.org changed reviewers: - matthieu.rigolot@gmail.com, thakis@chromium.org
tkent@chromium.org changed required reviewers: - thakis@chromium.org
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486809304216180, "parent_rev":
"d2a4caef5b812732dce7baa2d56716f8ae1f8cd2", "commit_rev":
"b0d6dc9fc0c9ad8b4944fa48125ad5bcf3f29146"}
Message was sent while issue was closed.
Description was changed from ========== Modify HTMLLabelElement::control to check if label is in tree scope HTMLLabelElement.control should not return the input element if <label> and <input> are in different trees. New behavior matches to the specification as per: https://html.spec.whatwg.org/#labeled-control BUG=683461 ========== to ========== Modify HTMLLabelElement::control to check if label is in tree scope HTMLLabelElement.control should not return the input element if <label> and <input> are in different trees. New behavior matches to the specification as per: https://html.spec.whatwg.org/#labeled-control BUG=683461 Review-Url: https://codereview.chromium.org/2692473003 Cr-Commit-Position: refs/heads/master@{#449855} Committed: https://chromium.googlesource.com/chromium/src/+/b0d6dc9fc0c9ad8b4944fa48125a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b0d6dc9fc0c9ad8b4944fa48125a... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
