third_party/WebKit/Source/core/html/HTMLLabelElement.cpp - Issue 2692473003: Modify HTMLLabelElement::control to check if label is in tree scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

Issue 2692473003: Modify HTMLLabelElement::control to check if label is in tree scope (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp b/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

index 191e9c178e957426f41061892417ab03a85f7cd1..546d8a5c743d9a119096aff2623967e4fe71cd76 100644

--- a/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLLabelElement.cpp

@@ -69,6 +69,9 @@ LabelableElement* HTMLLabelElement::control() const {

return nullptr;

}

+ if (!isInTreeScope())

+ return nullptr;

if (Element* element = treeScope().getElementById(controlId)) {

if (isLabelableElement(*element) &&

toLabelableElement(*element).supportLabels()) {