Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2692423008: Remove [NoInterfaceObject] from the USB interface. (Closed)

Created:
3 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove [NoInterfaceObject] from the USB interface. This was removed from the spec long ago but was not updated in Blink. With [NoInterfaceObject] I can't write LayoutTests like: assert_true(navigator.usb instanceof USB); BUG=None Review-Url: https://codereview.chromium.org/2692423008 Cr-Commit-Position: refs/heads/master@{#452141} Committed: https://chromium.googlesource.com/chromium/src/+/866dd346473c848d0eadfdd2c4e4e9cfc0381ca8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.idl View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Reilly Grant (use Gerrit)
PTAL
3 years, 10 months ago (2017-02-17 23:10:22 UTC) #2
Reilly Grant (use Gerrit)
Friendly ping.
3 years, 10 months ago (2017-02-22 16:26:47 UTC) #7
Jeffrey Yasskin
lgtm
3 years, 10 months ago (2017-02-22 16:49:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692423008/1
3 years, 10 months ago (2017-02-22 16:58:12 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 18:29:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/866dd346473c848d0eadfdd2c4e4...

Powered by Google App Engine
This is Rietveld 408576698