third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py - Issue 2692423005: rebaseline-cl: Get latest try jobs using git-cl when no --issue given.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

Issue 2692423005: rebaseline-cl: Get latest try jobs using git-cl when no --issue given. (Closed)

Patch Set: Rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

index 8a1401aaa9297ec1843e190a4532f5f277f3fc20..e536cea34a95495bb299a749c333c48ef475c30e 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

@@ -64,9 +64,11 @@ class RebaselineCL(AbstractParallelRebaselineCommand):

if not issue_number:

return 1

- # TODO(qyearsley): Replace this with git cl try-results to remove

- # dependency on Rietveld. See crbug.com/671684.

- builds = self.rietveld.latest_try_jobs(issue_number, self._try_bots())

+ # TODO(qyearsley): Remove dependency on Rietveld. See crbug.com/671684.

+ if options.issue:

+ builds = self.rietveld.latest_try_jobs(issue_number, self._try_bots())

+ else:

+ builds = self.git_cl().latest_try_jobs(self._try_bots())

if options.trigger_jobs:

if self.trigger_jobs_for_missing_builds(builds):