Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py

Issue 2692423005: rebaseline-cl: Get latest try jobs using git-cl when no --issue given. (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
index 2755169cb9210c7aa58c6d9030ee46ebd6fafc6c..8f39a5bd42b04c04d5bdef507bb99beafcfe6cec 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
@@ -93,27 +93,3 @@ class RietveldTest(LoggingTestCase):
def test_changed_files_no_results(self):
rietveld = Rietveld(self.mock_web())
self.assertIsNone(rietveld.changed_files(11113333))
-
- # Testing protected methods - pylint: disable=protected-access
-
- def test_filter_latest_jobs_empty(self):
- rietveld = Rietveld(self.mock_web())
- self.assertEqual(rietveld._filter_latest_builds([]), [])
-
- def test_filter_latest_jobs_higher_build_first(self):
- rietveld = Rietveld(self.mock_web())
- self.assertEqual(
- rietveld._filter_latest_builds([Build('foo', 5), Build('foo', 3), Build('bar', 5)]),
- [Build('bar', 5), Build('foo', 5)])
-
- def test_filter_latest_jobs_higher_build_last(self):
- rietveld = Rietveld(self.mock_web())
- self.assertEqual(
- rietveld._filter_latest_builds([Build('foo', 3), Build('bar', 5), Build('foo', 5)]),
- [Build('bar', 5), Build('foo', 5)])
-
- def test_filter_latest_jobs_no_build_number(self):
- rietveld = Rietveld(self.mock_web())
- self.assertEqual(
- rietveld._filter_latest_builds([Build('foo', 3), Build('bar'), Build('bar')]),
- [Build('bar'), Build('foo', 3)])

Powered by Google App Engine
This is Rietveld 408576698