| OLD | NEW |
| 1 # Copyright 2016 The Chromium Authors. All rights reserved. | 1 # Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """A command to fetch new baselines from try jobs for a Rietveld issue. | 5 """A command to fetch new baselines from try jobs for a Rietveld issue. |
| 6 | 6 |
| 7 This command interacts with the Rietveld API to get information about try jobs | 7 This command interacts with the Rietveld API to get information about try jobs |
| 8 with layout test results. | 8 with layout test results. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 57 if unstaged_baselines: | 57 if unstaged_baselines: |
| 58 _log.error('Aborting: there are unstaged baselines:') | 58 _log.error('Aborting: there are unstaged baselines:') |
| 59 for path in unstaged_baselines: | 59 for path in unstaged_baselines: |
| 60 _log.error(' %s', path) | 60 _log.error(' %s', path) |
| 61 return 1 | 61 return 1 |
| 62 | 62 |
| 63 issue_number = self._get_issue_number(options) | 63 issue_number = self._get_issue_number(options) |
| 64 if not issue_number: | 64 if not issue_number: |
| 65 return 1 | 65 return 1 |
| 66 | 66 |
| 67 # TODO(qyearsley): Replace this with git cl try-results to remove | 67 # TODO(qyearsley): Remove dependency on Rietveld. See crbug.com/671684. |
| 68 # dependency on Rietveld. See crbug.com/671684. | 68 if options.issue: |
| 69 builds = self.rietveld.latest_try_jobs(issue_number, self._try_bots()) | 69 builds = self.rietveld.latest_try_jobs(issue_number, self._try_bots(
)) |
| 70 else: |
| 71 builds = self.git_cl().latest_try_jobs(self._try_bots()) |
| 70 | 72 |
| 71 if options.trigger_jobs: | 73 if options.trigger_jobs: |
| 72 if self.trigger_jobs_for_missing_builds(builds): | 74 if self.trigger_jobs_for_missing_builds(builds): |
| 73 _log.info('Please re-run webkit-patch rebaseline-cl once all pen
ding try jobs have finished.') | 75 _log.info('Please re-run webkit-patch rebaseline-cl once all pen
ding try jobs have finished.') |
| 74 return 1 | 76 return 1 |
| 75 if not builds: | 77 if not builds: |
| 76 _log.info('No builds to download baselines from.') | 78 _log.info('No builds to download baselines from.') |
| 77 | 79 |
| 78 _log.debug('Getting results for Rietveld issue %d.', issue_number) | 80 _log.debug('Getting results for Rietveld issue %d.', issue_number) |
| 79 builds_to_results = self._fetch_results(builds) | 81 builds_to_results = self._fetch_results(builds) |
| (...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 238 def _log_test_prefix_list(test_prefix_list): | 240 def _log_test_prefix_list(test_prefix_list): |
| 239 """Logs the tests to download new baselines for.""" | 241 """Logs the tests to download new baselines for.""" |
| 240 if not test_prefix_list: | 242 if not test_prefix_list: |
| 241 _log.info('No tests to rebaseline; exiting.') | 243 _log.info('No tests to rebaseline; exiting.') |
| 242 return | 244 return |
| 243 _log.debug('Tests to rebaseline:') | 245 _log.debug('Tests to rebaseline:') |
| 244 for test, builds in test_prefix_list.iteritems(): | 246 for test, builds in test_prefix_list.iteritems(): |
| 245 _log.debug(' %s:', test) | 247 _log.debug(' %s:', test) |
| 246 for build in sorted(builds): | 248 for build in sorted(builds): |
| 247 _log.debug(' %s', build) | 249 _log.debug(' %s', build) |
| OLD | NEW |