The change in the tests from stack allocated nodes to heap allocated, is that a ...
3 years, 10 months ago
(2017-02-15 01:58:59 UTC)
#2
The change in the tests from stack allocated nodes to heap allocated, is that a
Persistent container has a DCHECK that it's object is heap allocated.
The more you know :).
cbiesinger
lgtm
3 years, 10 months ago
(2017-02-15 17:33:14 UTC)
#3
lgtm
ikilpatrick
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
3 years, 10 months ago
(2017-02-15 18:00:41 UTC)
#4
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487199484296260, "parent_rev": "5bbea159fd30c4f7f1af838e12bf5dccb39e5dae", "commit_rev": "a4d7e99f9043c0268d57258bb6ef1a6e206b6b1d"}
3 years, 10 months ago
(2017-02-16 00:45:24 UTC)
#12
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487199484296260,
"parent_rev": "5bbea159fd30c4f7f1af838e12bf5dccb39e5dae", "commit_rev":
"a4d7e99f9043c0268d57258bb6ef1a6e206b6b1d"}
commit-bot: I haz the power
Description was changed from ========== [LayoutNG] Make NGBlockLayoutAlgorithm accept a NGBlockNode. Instead of the LayoutObject, ...
3 years, 10 months ago
(2017-02-16 00:46:08 UTC)
#13
Message was sent while issue was closed.
Description was changed from
==========
[LayoutNG] Make NGBlockLayoutAlgorithm accept a NGBlockNode.
Instead of the LayoutObject, Style, FirstChild tuple.
This is so that NGFragmentBuilder can access the node to construct a
break token correctly.
See prototype multi-col patch: crrev/2693193002.
BUG=635619
==========
to
==========
[LayoutNG] Make NGBlockLayoutAlgorithm accept a NGBlockNode.
Instead of the LayoutObject, Style, FirstChild tuple.
This is so that NGFragmentBuilder can access the node to construct a
break token correctly.
See prototype multi-col patch: crrev/2693193002.
BUG=635619
Review-Url: https://codereview.chromium.org/2692403003
Cr-Commit-Position: refs/heads/master@{#450843}
Committed:
https://chromium.googlesource.com/chromium/src/+/a4d7e99f9043c0268d57258bb6ef...
==========
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a4d7e99f9043c0268d57258bb6ef1a6e206b6b1d
3 years, 10 months ago
(2017-02-16 00:46:09 UTC)
#14
Issue 2692403003: [LayoutNG] Make NGBlockLayoutAlgorithm accept a NGBlockNode.
(Closed)
Created 3 years, 10 months ago by ikilpatrick
Modified 3 years, 10 months ago
Reviewers: cbiesinger, Gleb Lanbin
Base URL:
Comments: 0