Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 2692403003: [LayoutNG] Make NGBlockLayoutAlgorithm accept a NGBlockNode. (Closed)

Created:
3 years, 10 months ago by ikilpatrick
Modified:
3 years, 10 months ago
Reviewers:
cbiesinger, Gleb Lanbin
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Make NGBlockLayoutAlgorithm accept a NGBlockNode. Instead of the LayoutObject, Style, FirstChild tuple. This is so that NGFragmentBuilder can access the node to construct a break token correctly. See prototype multi-col patch: crrev/2693193002. BUG=635619 Review-Url: https://codereview.chromium.org/2692403003 Cr-Commit-Position: refs/heads/master@{#450843} Committed: https://chromium.googlesource.com/chromium/src/+/a4d7e99f9043c0268d57258bb6ef1a6e206b6b1d

Patch Set 1 #

Patch Set 2 : comments! #

Messages

Total messages: 14 (8 generated)
ikilpatrick
The change in the tests from stack allocated nodes to heap allocated, is that a ...
3 years, 10 months ago (2017-02-15 01:58:59 UTC) #2
cbiesinger
lgtm
3 years, 10 months ago (2017-02-15 17:33:14 UTC) #3
Gleb Lanbin
lgtm
3 years, 10 months ago (2017-02-15 22:29:13 UTC) #8
Gleb Lanbin
lgtm
3 years, 10 months ago (2017-02-15 22:29:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692403003/20001
3 years, 10 months ago (2017-02-15 22:58:49 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 00:46:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a4d7e99f9043c0268d57258bb6ef...

Powered by Google App Engine
This is Rietveld 408576698