Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields. (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
index a27936877739c38686a1e84fe71353e113be172d..cb3c0ca4e6fe30db2919d057ef541165548ec2a4 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
@@ -11,8 +11,9 @@ PageLoadExtraInfo::PageLoadExtraInfo(
const base::Optional<base::TimeDelta>& first_foreground_time,
bool started_in_foreground,
UserInitiatedInfo user_initiated_info,
- const GURL& committed_url,
+ const GURL& url,
const GURL& start_url,
+ bool did_commit,
UserAbortType abort_type,
UserInitiatedInfo abort_user_initiated_info,
const base::Optional<base::TimeDelta>& time_to_abort,
@@ -21,8 +22,9 @@ PageLoadExtraInfo::PageLoadExtraInfo(
first_foreground_time(first_foreground_time),
started_in_foreground(started_in_foreground),
user_initiated_info(user_initiated_info),
- committed_url(committed_url),
+ url(url),
start_url(start_url),
+ did_commit(did_commit),
abort_type(abort_type),
abort_user_initiated_info(abort_user_initiated_info),
time_to_abort(time_to_abort),
« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/page_load_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698