Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields. (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h" 5 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
6 6
7 namespace page_load_metrics { 7 namespace page_load_metrics {
8 8
9 PageLoadExtraInfo::PageLoadExtraInfo( 9 PageLoadExtraInfo::PageLoadExtraInfo(
10 const base::Optional<base::TimeDelta>& first_background_time, 10 const base::Optional<base::TimeDelta>& first_background_time,
11 const base::Optional<base::TimeDelta>& first_foreground_time, 11 const base::Optional<base::TimeDelta>& first_foreground_time,
12 bool started_in_foreground, 12 bool started_in_foreground,
13 UserInitiatedInfo user_initiated_info, 13 UserInitiatedInfo user_initiated_info,
14 const GURL& committed_url, 14 const GURL& url,
15 const GURL& start_url, 15 const GURL& start_url,
16 bool did_commit,
16 UserAbortType abort_type, 17 UserAbortType abort_type,
17 UserInitiatedInfo abort_user_initiated_info, 18 UserInitiatedInfo abort_user_initiated_info,
18 const base::Optional<base::TimeDelta>& time_to_abort, 19 const base::Optional<base::TimeDelta>& time_to_abort,
19 const PageLoadMetadata& metadata) 20 const PageLoadMetadata& metadata)
20 : first_background_time(first_background_time), 21 : first_background_time(first_background_time),
21 first_foreground_time(first_foreground_time), 22 first_foreground_time(first_foreground_time),
22 started_in_foreground(started_in_foreground), 23 started_in_foreground(started_in_foreground),
23 user_initiated_info(user_initiated_info), 24 user_initiated_info(user_initiated_info),
24 committed_url(committed_url), 25 url(url),
25 start_url(start_url), 26 start_url(start_url),
27 did_commit(did_commit),
26 abort_type(abort_type), 28 abort_type(abort_type),
27 abort_user_initiated_info(abort_user_initiated_info), 29 abort_user_initiated_info(abort_user_initiated_info),
28 time_to_abort(time_to_abort), 30 time_to_abort(time_to_abort),
29 metadata(metadata) {} 31 metadata(metadata) {}
30 32
31 PageLoadExtraInfo::PageLoadExtraInfo(const PageLoadExtraInfo& other) = default; 33 PageLoadExtraInfo::PageLoadExtraInfo(const PageLoadExtraInfo& other) = default;
32 34
33 PageLoadExtraInfo::~PageLoadExtraInfo() {} 35 PageLoadExtraInfo::~PageLoadExtraInfo() {}
34 36
35 ExtraRequestInfo::ExtraRequestInfo(bool was_cached, 37 ExtraRequestInfo::ExtraRequestInfo(bool was_cached,
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 } 81 }
80 82
81 PageLoadMetricsObserver::ObservePolicy 83 PageLoadMetricsObserver::ObservePolicy
82 PageLoadMetricsObserver::FlushMetricsOnAppEnterBackground( 84 PageLoadMetricsObserver::FlushMetricsOnAppEnterBackground(
83 const PageLoadTiming& timing, 85 const PageLoadTiming& timing,
84 const PageLoadExtraInfo& extra_info) { 86 const PageLoadExtraInfo& extra_info) {
85 return CONTINUE_OBSERVING; 87 return CONTINUE_OBSERVING;
86 } 88 }
87 89
88 } // namespace page_load_metrics 90 } // namespace page_load_metrics
OLDNEW
« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/page_load_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698