chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc - Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc

Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields. (Closed)

Patch Set: address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc

index 149dfff57d1e70139f657b4f752961bb7ac9e426..0125164312986f7caa22b0b363d4df99441ae14e 100644

--- a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc

@@ -79,7 +79,7 @@ void ServiceWorkerPageLoadMetricsObserver::OnFirstContentfulPaint(

internal::kHistogramServiceWorkerParseStartToFirstContentfulPaint,

timing.first_contentful_paint.value() - timing.parse_start.value());

- if (IsInboxSite(info.committed_url)) {

+ if (IsInboxSite(info.url)) {

PAGE_LOAD_HISTOGRAM(

internal::kHistogramServiceWorkerFirstContentfulPaintInbox,

timing.first_contentful_paint.value());

@@ -100,7 +100,7 @@ void ServiceWorkerPageLoadMetricsObserver::OnDomContentLoadedEventStart(

}

PAGE_LOAD_HISTOGRAM(internal::kHistogramServiceWorkerDomContentLoaded,

timing.dom_content_loaded_event_start.value());

- if (IsInboxSite(info.committed_url)) {

+ if (IsInboxSite(info.url)) {

PAGE_LOAD_HISTOGRAM(internal::kHistogramServiceWorkerDomContentLoadedInbox,

timing.dom_content_loaded_event_start.value());

}

@@ -116,7 +116,7 @@ void ServiceWorkerPageLoadMetricsObserver::OnLoadEventStart(

return;

PAGE_LOAD_HISTOGRAM(internal::kHistogramServiceWorkerLoad,

timing.load_event_start.value());

- if (IsInboxSite(info.committed_url)) {

+ if (IsInboxSite(info.url)) {

PAGE_LOAD_HISTOGRAM(internal::kHistogramServiceWorkerLoadInbox,

timing.load_event_start.value());

}