chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc - Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc

Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields. (Closed)

Patch Set: address comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc

index 352d74f957eed6e72b50faa954b8ee4fd5e56a53..ac29ee9cac3a2baded76bdff620c0b484600d77b 100644

--- a/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.cc

@@ -51,8 +51,7 @@ HttpsEngagementPageLoadMetricsObserver::OnShown() {

void HttpsEngagementPageLoadMetricsObserver::OnComplete(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) {

- if (!extra_info.committed_url.is_valid() ||

- extra_info.committed_url.is_empty()) {

+ if (!extra_info.did_commit || !extra_info.url.is_valid()) {

return;

}

@@ -63,13 +62,13 @@ void HttpsEngagementPageLoadMetricsObserver::OnComplete(

if (currently_in_foreground_)

OnHidden(timing, extra_info);

- if (extra_info.committed_url.SchemeIs(url::kHttpsScheme)) {

+ if (extra_info.url.SchemeIs(url::kHttpsScheme)) {

if (engagement_service_)

engagement_service_->RecordTimeOnPage(foreground_time_,

HttpsEngagementService::HTTPS);

UMA_HISTOGRAM_LONG_TIMES_100(internal::kHttpsEngagementHistogram,

foreground_time_);

- } else if (extra_info.committed_url.SchemeIs(url::kHttpScheme)) {

+ } else if (extra_info.url.SchemeIs(url::kHttpScheme)) {

if (engagement_service_)

engagement_service_->RecordTimeOnPage(foreground_time_,

HttpsEngagementService::HTTP);