Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2692353003: Mojo C++ bindings: remove some usage of AssociatedGroup from user code. (Closed)

Created:
3 years, 10 months ago by yzshen1
Modified:
3 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: remove some usage of AssociatedGroup from user code. This class is now supposed to be used in bindings-internal code. Users don't have to know about it. This CL changes components/leveldb/. Changes to other folders will be in follow-up CLs. BUG=682334 Review-Url: https://codereview.chromium.org/2692353003 Cr-Commit-Position: refs/heads/master@{#450849} Committed: https://chromium.googlesource.com/chromium/src/+/6c1b846f0ba70c7a0b84bd381caec44ed4ddcf88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -36 lines) Patch
M components/leveldb/leveldb_service_unittest.cc View 11 chunks +15 lines, -33 lines 0 comments Download
M components/leveldb/remote_iterator_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
yzshen1
Hi, Elliot. Would you please take a look? Thanks!
3 years, 10 months ago (2017-02-15 20:14:40 UTC) #3
Elliot Glaysher
lgtm
3 years, 10 months ago (2017-02-15 20:16:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692353003/1
3 years, 10 months ago (2017-02-16 00:01:59 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 00:55:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c1b846f0ba70c7a0b84bd381cae...

Powered by Google App Engine
This is Rietveld 408576698