third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h - Issue 2692233005: Fix hyphenated words not to overflow on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Issue 2692233005: Fix hyphenated words not to overflow on Android (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

diff --git a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

index e329fe305bb462f196fbec2da629da6641911711..5d37829464c3cc6fdd77f7954481e20e2406f11f 100644

--- a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

+++ b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

@@ -890,6 +890,7 @@ ALWAYS_INLINE bool BreakingContext::hyphenate(

unsigned prefixLength = hyphenation.lastHyphenLocation(

StringView(text.text(), start, len),

std::min(maxPrefixLength, len - Hyphenation::minimumSuffixLength) + 1);

+ DCHECK_LE(prefixLength, maxPrefixLength);

if (!prefixLength || prefixLength < Hyphenation::minimumPrefixLength)

return false;

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »