[WPT Export] Fix cwd on run_command calls in ChromiumCommit

[WPT Export] Fix cwd on run_command calls in ChromiumCommit

Trying to diagnose this failure:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-exporter%2F154%2F%2B%2Frecipes%2Fsteps%2Fcreate_PR_or_merge_in-flight_PR%2F0%2Fstdout

This adds the cwd= argument to all shell calls in ChromiumCommit and also enforces that the sha argument to ChromiumCommit is a valid SHA-1 (40 chars long).

BUG=

Review-Url: https://codereview.chromium.org/2692233002
Cr-Commit-Position: refs/heads/master@{#450453}
Committed: https://chromium.googlesource.com/chromium/src/+/82685a6d33c5fc39406f5a522000fc72c732bf96

[jeffcarp, 2017-02-14 02:19:25]

Description was changed from

==========
[WPT Export] Fix cwd on run_command calls in Chromium

BUG=
==========

to

==========
[WPT Export] Fix cwd on run_command calls in ChromiumCommit

Trying to diagnose this failure:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwp...

This adds the cwd= argument to all shell calls in ChromiumCommit and also
enforces that the sha argument to ChromiumCommit is a valid SHA-1 (40 chars
long).

BUG=
==========

[jeffcarp, 2017-02-14 02:19:25]

jeffcarp@chromium.org changed reviewers:
+ qyearsley@chromium.org

[jeffcarp, 2017-02-14 02:19:32]

jeffcarp@chromium.org changed reviewers:
- qyearsley@chromium.org

[jeffcarp, 2017-02-14 02:19:46]

jeffcarp@chromium.org changed reviewers:
+ qyearsley@chromium.org

[jeffcarp, 2017-02-14 02:20:48]

https://codereview.chromium.org/2692233002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/common_unittest.py (right):

https://codereview.chromium.org/2692233002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/common_unittest.py:27: 
The only changes in the tests are the 1. addition of this function and 2. the
replacement of all placeholder hex values with real SHA-1 hashes.

[qyearsley, 2017-02-14 05:17:34]

lgtm; note, I think that when we refactor these calls to git to use the Git
class, the cwd handling may be simpler, since finding the right cwd is part of
the Git constructor.

https://codereview.chromium.org/2692233002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/common_unittest.py (right):

https://codereview.chromium.org/2692233002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/common_unittest.py:27: 
On 2017/02/14 at 02:20:48, jeffcarp wrote:
> The only changes in the tests are the 1. addition of this function and 2. the
replacement of all placeholder hex values with real SHA-1 hashes.

Optional possible change to this function; since you have two similar functions
that vary in one small way, you could also combine them into:

def mock_command_exec(vals, strict=False):
    def run_fn(args):
        sub_command = args[1]
        if strict and sub_command not in vals:
            raise AssertionError('...')
        return vals.get(sub_command, '')
    return MockExecutive(run_command_fn=run_fn)

[jeffcarp, 2017-02-14 19:27:46]

Going to send to CQ now to try to fix wpt-exporter bot problems, will follow up
with the improvement you suggested.

[jeffcarp, 2017-02-14 19:27:48]

The CQ bit was checked by jeffcarp@chromium.org

[commit-bot: I haz the power, 2017-02-14 19:28:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 20:37:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487100468671070,
"parent_rev": "0fa77b1e2deb7bd23bb777cfdc2a86de187f737e", "commit_rev":
"bc600548557bf6f11f59d11a60ff67395b0810fa"}

[commit-bot: I haz the power, 2017-02-14 20:41:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487100468671070,
"parent_rev": "822f125b058cb9cd5bd83e9a27de4db4251063e1", "commit_rev":
"82685a6d33c5fc39406f5a522000fc72c732bf96"}

[commit-bot: I haz the power, 2017-02-14 20:42:05]

Description was changed from

==========
[WPT Export] Fix cwd on run_command calls in ChromiumCommit

Trying to diagnose this failure:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwp...

This adds the cwd= argument to all shell calls in ChromiumCommit and also
enforces that the sha argument to ChromiumCommit is a valid SHA-1 (40 chars
long).

BUG=
==========

to

==========
[WPT Export] Fix cwd on run_command calls in ChromiumCommit

Trying to diagnose this failure:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwp...

This adds the cwd= argument to all shell calls in ChromiumCommit and also
enforces that the sha argument to ChromiumCommit is a valid SHA-1 (40 chars
long).

BUG=

Review-Url: https://codereview.chromium.org/2692233002
Cr-Commit-Position: refs/heads/master@{#450453}
Committed:
https://chromium.googlesource.com/chromium/src/+/82685a6d33c5fc39406f5a522000...
==========

[commit-bot: I haz the power, 2017-02-14 20:42:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/82685a6d33c5fc39406f5a522000...