Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py

Issue 2692233002: [WPT Export] Fix cwd on run_command calls in ChromiumCommit (Closed)
Patch Set: Strictly assert that SHA-1 hash was passed to ChromiumCommit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py
index 0533e3df33b415c7a06344655a10bf2e6830eb69..30afa5a583dbbec790bb1a89c6941e0d01dc6ddb 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit_unittest.py
@@ -15,19 +15,19 @@ CHROMIUM_WPT_DIR = 'third_party/WebKit/LayoutTests/external/wpt/'
class ChromiumCommitTest(unittest.TestCase):
def test_accepts_sha(self):
- chromium_commit = ChromiumCommit(MockHost(), sha='deadbeefcafe')
+ chromium_commit = ChromiumCommit(MockHost(), sha='c881563d734a86f7d9cd57ac509653a61c45c240')
- self.assertEqual(chromium_commit.sha, 'deadbeefcafe')
+ self.assertEqual(chromium_commit.sha, 'c881563d734a86f7d9cd57ac509653a61c45c240')
self.assertIsNone(chromium_commit.position)
def test_derives_sha_from_position(self):
host = MockHost()
- host.executive = MockExecutive(output='deadbeefcafe')
+ host.executive = MockExecutive(output='c881563d734a86f7d9cd57ac509653a61c45c240')
pos = 'Cr-Commit-Position: refs/heads/master@{#789}'
chromium_commit = ChromiumCommit(host, position=pos)
self.assertEqual(chromium_commit.position, 'refs/heads/master@{#789}')
- self.assertEqual(chromium_commit.sha, 'deadbeefcafe')
+ self.assertEqual(chromium_commit.sha, 'c881563d734a86f7d9cd57ac509653a61c45c240')
def test_filtered_changed_files_blacklist(self):
host = MockHost()
@@ -37,7 +37,7 @@ class ChromiumCommitTest(unittest.TestCase):
host.executive = mock_command_exec({
'diff-tree': '\n'.join(qualified_fake_files),
- 'crrev-parse': 'fake rev',
+ 'crrev-parse': 'c881563d734a86f7d9cd57ac509653a61c45c240',
})
position_footer = 'Cr-Commit-Position: refs/heads/master@{#789}'

Powered by Google App Engine
This is Rietveld 408576698