Reland: MD Settings: Fix the Network Prediction toggle box.

Reland: MD Settings: Fix the Network Prediction toggle box.

In order to fix this toggle, I had to update the
SettingsBooleanControlBehavior to support non 0/1 values for numeric
prefs.

BUG=664048
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2692213005
Cr-Commit-Position: refs/heads/master@{#450887}
Committed: https://chromium.googlesource.com/chromium/src/+/320e0b9c23efe8b8e037054a0e17310d5c1d346d

[tommycli, 2017-02-15 01:11:16]

Description was changed from

==========
Reland: MD Settings: Fix the Network Prediction toggle box.

In order to fix this toggle, I had to update the
SettingsBooleanControlBehavior to support non 0/1 values for numeric
prefs.

BUG=664048
==========

to

==========
Reland: MD Settings: Fix the Network Prediction toggle box.

In order to fix this toggle, I had to update the
SettingsBooleanControlBehavior to support non 0/1 values for numeric
prefs.

BUG=664048
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-02-15 01:39:46]

Patchset #2 (id:20001) has been deleted

[tommycli, 2017-02-15 01:41:03]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 01:42:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 04:45:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 04:45:25]

Dry run: This issue passed the CQ dry run.

[tommycli, 2017-02-15 16:49:19]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2017-02-15 16:49:20]

dbeam: PTAL

PS1 is original
PS2 is a rebase
PS3 contains changes that only trigger a pref update if toggle gets a user
gesture. Manually tested, updated tests... doesn't break other tests.

Thanks!

Tommy

[Dan Beam, 2017-02-15 23:25:53]

lgtm

https://codereview.chromium.org/2692213005/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js
(right):

https://codereview.chromium.org/2692213005/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js:64:
numericUncheckedValue: {
nit: does readOnly: true, work here?

https://codereview.chromium.org/2692213005/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_toggle_button_tests.js (right):

https://codereview.chromium.org/2692213005/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_toggle_button_tests.js:114:
testElement.numericUncheckedValue = 5;
you might need to change this

[tommycli, 2017-02-15 23:36:52]

thanks! submitting

https://codereview.chromium.org/2692213005/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js
(right):

https://codereview.chromium.org/2692213005/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js:64:
numericUncheckedValue: {
On 2017/02/15 23:25:53, Dan Beam wrote:
> nit: does readOnly: true, work here?

Done. Did a quick scan of the code. Doesn't look like anyone sets checked on one
of these anyways.

https://codereview.chromium.org/2692213005/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_toggle_button_tests.js (right):

https://codereview.chromium.org/2692213005/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_toggle_button_tests.js:114:
testElement.numericUncheckedValue = 5;
On 2017/02/15 23:25:53, Dan Beam wrote:
> you might need to change this

Done.

[tommycli, 2017-02-15 23:36:55]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-02-15 23:36:56]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2692213005/#ps80001
(title: "Address comments")

[commit-bot: I haz the power, 2017-02-15 23:38:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 01:42:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:42:06]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[tommycli, 2017-02-16 02:07:25]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-02-16 02:08:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 04:10:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 04:10:48]

Exceeded global retry quota

[Dan Beam, 2017-02-16 04:30:33]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-02-16 04:31:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 07:23:37]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487219433488830,
"parent_rev": "31b20b5b80ab095dafa26b198fd7208d6fef2be5", "commit_rev":
"320e0b9c23efe8b8e037054a0e17310d5c1d346d"}

[commit-bot: I haz the power, 2017-02-16 07:25:33]

Description was changed from

==========
Reland: MD Settings: Fix the Network Prediction toggle box.

In order to fix this toggle, I had to update the
SettingsBooleanControlBehavior to support non 0/1 values for numeric
prefs.

BUG=664048
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Reland: MD Settings: Fix the Network Prediction toggle box.

In order to fix this toggle, I had to update the
SettingsBooleanControlBehavior to support non 0/1 values for numeric
prefs.

BUG=664048
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2692213005
Cr-Commit-Position: refs/heads/master@{#450887}
Committed:
https://chromium.googlesource.com/chromium/src/+/320e0b9c23efe8b8e037054a0e17...
==========

[commit-bot: I haz the power, 2017-02-16 07:25:34]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/320e0b9c23efe8b8e037054a0e17...