Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: chrome/test/data/webui/settings/checkbox_tests.js

Issue 2692213005: Reland: MD Settings: Fix the Network Prediction toggle box. (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/checkbox_tests.js
diff --git a/chrome/test/data/webui/settings/checkbox_tests.js b/chrome/test/data/webui/settings/checkbox_tests.js
index a41419f422f87a501af42246d2e4adaf5a3f4483..f7f9d9ef0b204d855e882742d86315fb93ffb527 100644
--- a/chrome/test/data/webui/settings/checkbox_tests.js
+++ b/chrome/test/data/webui/settings/checkbox_tests.js
@@ -30,14 +30,14 @@ cr.define('settings_checkbox', function() {
document.body.appendChild(testElement);
});
- test('responds to checked attribute', function() {
+ test('value changes on tap', function() {
assertTrue(testElement.checked);
- testElement.removeAttribute('checked');
+ MockInteractions.tap(testElement.$.checkbox);
assertFalse(testElement.checked);
assertFalse(pref.value);
- testElement.setAttribute('checked', '');
+ MockInteractions.tap(testElement.$.checkbox);
assertTrue(testElement.checked);
assertTrue(pref.value);
});
@@ -71,11 +71,11 @@ cr.define('settings_checkbox', function() {
testElement.set('pref', prefNum);
assertTrue(testElement.checked);
- testElement.removeAttribute('checked');
+ MockInteractions.tap(testElement.$.checkbox);
assertFalse(testElement.checked);
assertEquals(0, prefNum.value);
- testElement.setAttribute('checked', '');
+ MockInteractions.tap(testElement.$.checkbox);
assertTrue(testElement.checked);
assertEquals(1, prefNum.value);
});

Powered by Google App Engine
This is Rietveld 408576698