Implemented SetSelection for the Web content on Windows.

Implemented SetSelection for the Web content on Windows.

Still preliminary but you may have a first look. I'll improve the tests and fix any bugs tomorrow.
First use of |AXPosition| in Windows code.
BUG=487655
R=dmazzoni@chromium.org
TESTED=browser tests

Review-Url: https://codereview.chromium.org/2692173003
Cr-Commit-Position: refs/heads/master@{#451681}
Committed: https://chromium.googlesource.com/chromium/src/+/71c782dbd99254aeaf261691bbffdd34cc551e9e

[dmazzoni, 2017-02-14 20:17:58]

lgtm

Very well done! AXPosition seems to be working well
for this use case.

One idea for later would be to write a helper function
that takes some HTML and a start and end offset, then
tries to set the selection to those offsets and checks
that we get the same one back. Then we could basically
call that helper with a bunch of different HTML snippets
to test that it works correctly.

It may not be necessary to do that in Win-specific
code, though. Most of that is cross-platform.

https://codereview.chromium.org/2692173003/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/2692173003/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_win.cc:4194:
BrowserAccessibilityWin::AXPlatformPositionInstance
can you make this shorter with the "using" keyword, like:

using AXBrowserPosition = BrowserAccessibilityWin::AXPlatformPositionInstance;

[nektarios, 2017-02-16 20:30:05]

The CQ bit was checked by nektar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 20:31:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 20:53:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 20:53:17]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[nektarios, 2017-02-16 22:05:34]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-02-16 22:05:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2692173003/#ps40001
(title: "Fixed compilation error on Android.")

[commit-bot: I haz the power, 2017-02-16 22:07:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 22:36:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 22:36:11]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nektarios, 2017-02-16 22:55:10]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-02-16 22:55:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2692173003/#ps60001
(title: "Fixed Mac compilation error.")

[commit-bot: I haz the power, 2017-02-16 22:56:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 23:58:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 23:58:10]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[nektarios, 2017-02-17 01:30:53]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-02-17 01:30:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2692173003/#ps80001
(title: "Out params used in Component Object Model calls may be set to a default
value if an invalid input p…")

[commit-bot: I haz the power, 2017-02-17 01:33:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:47:53]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[nektarios, 2017-02-17 21:38:36]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2017-02-17 21:38:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2692173003/#ps100001
(title: "Fixed another compilation error on Windows.")

[commit-bot: I haz the power, 2017-02-17 21:39:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:19:11]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nektarios, 2017-02-18 01:34:53]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:37:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 03:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:39:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[nektarios, 2017-02-20 23:54:56]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2017-02-20 23:55:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 01:14:42]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487634896138990,
"parent_rev": "dbb8e93309e26cfb52bcc374c4a8ee81dc98ec43", "commit_rev":
"71c782dbd99254aeaf261691bbffdd34cc551e9e"}

[commit-bot: I haz the power, 2017-02-21 01:15:40]

Description was changed from

==========
Implemented SetSelection for the Web content on Windows.

Still preliminary but you may have a first look. I'll improve the tests and fix
any bugs tomorrow.
First use of |AXPosition| in Windows code.
BUG=487655
R=dmazzoni@chromium.org
TESTED=browser tests
==========

to

==========
Implemented SetSelection for the Web content on Windows.

Still preliminary but you may have a first look. I'll improve the tests and fix
any bugs tomorrow.
First use of |AXPosition| in Windows code.
BUG=487655
R=dmazzoni@chromium.org
TESTED=browser tests

Review-Url: https://codereview.chromium.org/2692173003
Cr-Commit-Position: refs/heads/master@{#451681}
Committed:
https://chromium.googlesource.com/chromium/src/+/71c782dbd99254aeaf261691bbff...
==========

[commit-bot: I haz the power, 2017-02-21 01:15:41]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/71c782dbd99254aeaf261691bbff...