Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 2692173003: Implemented SetSelection for the Web content on Windows. (Closed)
Patch Set: Fixed another compilation error on Windows. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_cocoa.mm
diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm
index 2142d7f8d24837b34036475e9881249671f3ec09..e2dcfb2074bddcb183d18ebc2fdfad21c385d80c 100644
--- a/content/browser/accessibility/browser_accessibility_cocoa.mm
+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm
@@ -959,8 +959,7 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";
if (!root)
return nil;
- AXPlatformPositionInstance position =
- CreateTextPosition(*root, 0, ui::AX_TEXT_AFFINITY_DOWNSTREAM);
+ AXPlatformPositionInstance position = root->CreatePositionAt(0);
return CreateTextMarker(position->CreatePositionAtEndOfAnchor());
}
@@ -1719,8 +1718,7 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";
if (!root)
return nil;
- AXPlatformPositionInstance position =
- CreateTextPosition(*root, 0, ui::AX_TEXT_AFFINITY_DOWNSTREAM);
+ AXPlatformPositionInstance position = root->CreatePositionAt(0);
return CreateTextMarker(position->CreatePositionAtStartOfAnchor());
}
@@ -2128,8 +2126,8 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";
}
if ([attribute isEqualToString:@"AXTextMarkerRangeForUIElement"]) {
- AXPlatformPositionInstance startPosition = CreateTextPosition(
- *browserAccessibility_, 0, ui::AX_TEXT_AFFINITY_DOWNSTREAM);
+ AXPlatformPositionInstance startPosition =
+ browserAccessibility_->CreatePositionAt(0);
AXPlatformPositionInstance endPosition =
startPosition->CreatePositionAtEndOfAnchor();
AXPlatformRange range =
@@ -2779,8 +2777,9 @@ NSString* const NSAccessibilityRequiredAttribute = @"AXRequired";
if ([attribute isEqualToString:NSAccessibilitySelectedTextRangeAttribute]) {
NSRange range = [(NSValue*)value rangeValue];
BrowserAccessibilityManager* manager = browserAccessibility_->manager();
- manager->SetTextSelection(
- *browserAccessibility_, range.location, range.location + range.length);
+ manager->SetSelection(AXPlatformRange(
+ browserAccessibility_->CreatePositionAt(range.location),
+ browserAccessibility_->CreatePositionAt(NSMaxRange(range))));
}
}
« no previous file with comments | « content/browser/accessibility/browser_accessibility.cc ('k') | content/browser/accessibility/browser_accessibility_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698