Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2692123002: Revert of Shape detection unittests mac (QR and Face) in GPU bots (Closed)

Created:
3 years, 10 months ago by Garrett Casto
Modified:
3 years, 10 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Shape detection unittests mac (QR and Face) in GPU bots (patchset #6 id:280001 of https://codereview.chromium.org/2677553003/ ) Reason for revert: This causes a failure in service_unittest for Mac 10.10: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests Original issue's description: > Shape detection unittests mac (QR and Face) in GPU bots > > This CL adds {Barcode,Face}Detection Mac unittests as part of > service_unittests. These new tests are run in the gpu bots, bc > the normal Mac bots don't have GPUs and that seems to screw > the CoreImage library (FTR I tried loading the lib and symbols in > runtime and/or using a software rendering context, see PS2, but > that didn't solve the problem). > > BUG=665150, 659139 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2677553003 > Cr-Commit-Position: refs/heads/master@{#450061} > Committed: https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b3a50f8d43865 TBR=rockot@chromium.org,kbr@chromium.org,rsesek@chromium.org,bajones@chromium.org,erg@chromium.org,bsalomon@chromium.org,bsalomon@google.com,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=665150, 659139 Review-Url: https://codereview.chromium.org/2692123002 Cr-Commit-Position: refs/heads/master@{#450094} Committed: https://chromium.googlesource.com/chromium/src/+/bcc0e7acd0729e980c81a73ba7968045470711e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -570 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 1 chunk +0 lines, -12 lines 0 comments Download
M services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/shape_detection/BUILD.gn View 2 chunks +0 lines, -27 lines 0 comments Download
M services/shape_detection/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D services/shape_detection/PRESUBMIT.py View 1 chunk +0 lines, -36 lines 0 comments Download
M services/shape_detection/barcode_detection_impl_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
D services/shape_detection/barcode_detection_impl_mac_unittest.mm View 1 chunk +0 lines, -99 lines 0 comments Download
M services/shape_detection/face_detection_impl_mac.mm View 2 chunks +4 lines, -4 lines 0 comments Download
D services/shape_detection/face_detection_impl_mac_unittest.mm View 1 chunk +0 lines, -100 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 17 chunks +0 lines, -287 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Garrett Casto
Created Revert of Shape detection unittests mac (QR and Face) in GPU bots
3 years, 10 months ago (2017-02-13 21:22:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692123002/1
3 years, 10 months ago (2017-02-13 21:23:14 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 21:25:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bcc0e7acd0729e980c81a73ba796...

Powered by Google App Engine
This is Rietveld 408576698