Shape detection unittests mac (QR and Face) in GPU bots

Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
service_unittests.  These new tests are run in the gpu bots, bc 
the normal Mac bots don't have GPUs and that seems to screw 
the CoreImage library (FTR I tried loading the lib and symbols in 
runtime and/or using a software rendering context, see PS2, but 
that didn't solve the problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2677553003
Cr-Commit-Position: refs/heads/master@{#450061}
Committed: https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b3a50f8d43865

[mcasas, 2017-02-03 19:06:11]

Patchset #1 (id:1) has been deleted

[mcasas, 2017-02-04 01:08:11]

Description was changed from

==========
Shape detection mac: unittests for QR and Face

WIP

BUG=665150, 659139
==========

to

==========
Shape detection mac: unittests for QR and Face

WIP

{Barcode,Face}Detection Mac unittests as part of service_unittests.
Need to jump through hoops because CIImage needs a GPU, which
the bots don't have :-(

BUG=665150, 659139
==========

[mcasas, 2017-02-04 01:26:39]

Patchset #2 (id:40001) has been deleted

[mcasas, 2017-02-10 15:29:18]

Description was changed from

==========
Shape detection mac: unittests for QR and Face

WIP

{Barcode,Face}Detection Mac unittests as part of service_unittests.
Need to jump through hoops because CIImage needs a GPU, which
the bots don't have :-(

BUG=665150, 659139
==========

to

==========
Shape detection mac: unittests for QR and Face

WIP

{Barcode,Face}Detection Mac unittests as part of service_unittests.
Need to jump through hoops because CIImage needs a GPU, which
the bots don't have :-(

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

BUG=665150, 659139
==========

[mcasas, 2017-02-10 18:06:35]

Patchset #2 (id:60001) has been deleted

[mcasas, 2017-02-10 18:06:42]

Patchset #2 (id:80001) has been deleted

[mcasas, 2017-02-10 18:14:22]

Patchset #3 (id:120001) has been deleted

[mcasas, 2017-02-10 18:14:29]

Patchset #3 (id:140001) has been deleted

[mcasas, 2017-02-10 18:18:18]

Description was changed from

==========
Shape detection mac: unittests for QR and Face

WIP

{Barcode,Face}Detection Mac unittests as part of service_unittests.
Need to jump through hoops because CIImage needs a GPU, which
the bots don't have :-(

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

BUG=665150, 659139
==========

to

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

BUG=665150, 659139
==========

[mcasas, 2017-02-10 18:36:48]

Description was changed from

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

BUG=665150, 659139
==========

to

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

BUG=665150, 659139
==========

[mcasas, 2017-02-10 18:40:57]

Description was changed from

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

BUG=665150, 659139
==========

to

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-02-10 18:40:57]

Description was changed from

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[mcasas, 2017-02-10 18:42:14]

Description was changed from

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

BUG=665150, 659139
==========

[mcasas, 2017-02-10 18:43:03]

Description was changed from

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

BUG=665150, 659139
==========

to

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-02-10 18:43:03]

Description was changed from

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[mcasas, 2017-02-10 18:43:14]

Patchset #4 (id:180001) has been deleted

[mcasas, 2017-02-10 18:43:23]

Patchset #3 (id:160001) has been deleted

[mcasas, 2017-02-10 18:44:20]

mcasas@chromium.org changed reviewers:
+ kbr@chromium.org, rsesek@chromium.org

[mcasas, 2017-02-10 18:44:21]

rsesek@ PTAL at Mac unittests plz

kbr@ follow your instructions to add the unittests to the
bots, thanks, yay! PTAL

[Robert Sesek, 2017-02-10 20:24:37]

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
File services/shape_detection/BUILD.gn (right):

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/BUILD.gn:54: if (is_mac) {
This may complain on non-Mac about an empty target when building all.

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
File services/shape_detection/barcode_detection_impl_mac_unittest.mm (right):

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/barcode_detection_impl_mac_unittest.mm:18:
BarcodeDetectionImplMacTest() = default;
Do you need to provide a ctor and dtor here?

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/barcode_detection_impl_mac_unittest.mm:51:
EXPECT_TRUE([qr_code_generator respondsToSelector:@selector(outputImage)]);
Won't this test then fail on 10.9?

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/barcode_detection_impl_mac_unittest.mm:62: [context
createCGImage:qr_code_image fromRect:[qr_code_image extent]];
This API follows the "create" rule for memory management, so this is currently
leaked.

https://developer.apple.com/library/content/documentation/CoreFoundation/Conc...

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/barcode_detection_impl_mac_unittest.mm:67:
CGDataProviderCopyData(CGImageGetDataProvider(cg_image));
Same; the "copy" rule indicates a strong reference, so this is leaked.

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
File services/shape_detection/face_detection_impl_mac_unittest.mm (right):

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/face_detection_impl_mac_unittest.mm:27: 
char* -> char[]

Though I think it'd be better to check this in as a data file, but i'm not sure
how services/ are supposed to access test data.

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/face_detection_impl_mac_unittest.mm:32:
FaceDetectionImplMacTest() = default;
Do you need to provide a ctor and dtor here?

[mcasas, 2017-02-10 21:05:05]

mcasas@chromium.org changed reviewers:
+ rockot@chromium.org

[mcasas, 2017-02-10 21:05:06]

ptal

+rockot@ PTAL at the new stuff in services/shape_detection

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
File services/shape_detection/BUILD.gn (right):

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/BUILD.gn:54: if (is_mac) {
On 2017/02/10 20:24:37, Robert Sesek wrote:
> This may complain on non-Mac about an empty target when building all.

Done.

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
File services/shape_detection/barcode_detection_impl_mac_unittest.mm (right):

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/barcode_detection_impl_mac_unittest.mm:18:
BarcodeDetectionImplMacTest() = default;
On 2017/02/10 20:24:37, Robert Sesek wrote:
> Do you need to provide a ctor and dtor here?

Ah yeah (and also in the face detection unittest). It was
needed because of the DISALLOW_COPY_AND_ASSIGN
that I wrote out of custom. Removed that and the
default ctor.

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/barcode_detection_impl_mac_unittest.mm:51:
EXPECT_TRUE([qr_code_generator respondsToSelector:@selector(outputImage)]);
On 2017/02/10 20:24:37, Robert Sesek wrote:
> Won't this test then fail on 10.9?

Yes although the bots are 10.11.4 and there's code 
in BarcodeDetectionImplMac to prevent its use before 
10.10.  Nevertheless I'll add a check here.

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/barcode_detection_impl_mac_unittest.mm:62: [context
createCGImage:qr_code_image fromRect:[qr_code_image extent]];
On 2017/02/10 20:24:37, Robert Sesek wrote:
> This API follows the "create" rule for memory management, so this is currently
> leaked.
> 
>
https://developer.apple.com/library/content/documentation/CoreFoundation/Conc...

Done.

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/barcode_detection_impl_mac_unittest.mm:67:
CGDataProviderCopyData(CGImageGetDataProvider(cg_image));
On 2017/02/10 20:24:37, Robert Sesek wrote:
> Same; the "copy" rule indicates a strong reference, so this is leaked.

Done.

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
File services/shape_detection/face_detection_impl_mac_unittest.mm (right):

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/face_detection_impl_mac_unittest.mm:27: 
On 2017/02/10 20:24:37, Robert Sesek wrote:
> char* -> char[]
> 
> Though I think it'd be better to check this in as a data file, but i'm not
sure
> how services/ are supposed to access test data.

I thought it better to just dump it here to avoid having a 
stand alone file for just this case, and to keep its origin
in the code.  Let's see what kbr@ and rockot@ say about 
it. Done changing to char[].

https://codereview.chromium.org/2677553003/diff/200001/services/shape_detecti...
services/shape_detection/face_detection_impl_mac_unittest.mm:32:
FaceDetectionImplMacTest() = default;
On 2017/02/10 20:24:37, Robert Sesek wrote:
> Do you need to provide a ctor and dtor here?

Acknowledged.

[Ken Rockot(use gerrit already), 2017-02-10 23:41:09]

lg2m but i'll wait until the service_unittests target is also updated for stamp

[Ken Rockot(use gerrit already), 2017-02-10 23:45:43]

https://codereview.chromium.org/2677553003/diff/220001/services/shape_detecti...
File services/shape_detection/barcode_detection_impl_mac_unittest.mm (right):

https://codereview.chromium.org/2677553003/diff/220001/services/shape_detecti...
services/shape_detection/barcode_detection_impl_mac_unittest.mm:89:
base::RunLoop().RunUntilIdle();
Same comment as the other file re RunUntilIdle.

https://codereview.chromium.org/2677553003/diff/220001/services/shape_detecti...
File services/shape_detection/face_detection_impl_mac_unittest.mm (right):

https://codereview.chromium.org/2677553003/diff/220001/services/shape_detecti...
services/shape_detection/face_detection_impl_mac_unittest.mm:84:
base::RunLoop().RunUntilIdle();
Actually, could you please refrain from using RunUntilIdle()? The detail that
all local message pipe messages are fully routed by the time the MessageLoop
goes idle is a totally internal detail of the system, not a guarantee which is
made by the APIs. It's true in practice today but I strongly encourage you to be
explicit about quitting the RunLoop in response to some event, e.g. just Run() a
RunLoop and have DetectCallback invoke its QuitClosure.

[mcasas, 2017-02-11 00:28:48]

Description was changed from

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
a new shape_detection_unittests. 

The reason to have this as a separate target is that normal mac 
bots don't have GPUs and that seems to screw the CoreImage 
library (FTR I tried loading the lib and symbols in runtime and/or 
using a software rendering context, but that didn't solve the 
problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
service_unittests.  These new tests are run in the gpu bots, bc 
the normal Mac bots don't have GPUs and that seems to screw 
the CoreImage library (FTR I tried loading the lib and symbols in 
runtime and/or using a software rendering context, see PS2, but 
that didn't solve the problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[mcasas, 2017-02-11 00:56:40]

Done merging into service_unittests, ptal

https://codereview.chromium.org/2677553003/diff/220001/services/shape_detecti...
File services/shape_detection/face_detection_impl_mac_unittest.mm (right):

https://codereview.chromium.org/2677553003/diff/220001/services/shape_detecti...
services/shape_detection/face_detection_impl_mac_unittest.mm:84:
base::RunLoop().RunUntilIdle();
On 2017/02/10 23:45:43, Ken Rockot wrote:
> Actually, could you please refrain from using RunUntilIdle()? The detail that
> all local message pipe messages are fully routed by the time the MessageLoop
> goes idle is a totally internal detail of the system, not a guarantee which is
> made by the APIs. It's true in practice today but I strongly encourage you to
be
> explicit about quitting the RunLoop in response to some event, e.g. just Run()
a
> RunLoop and have DetectCallback invoke its QuitClosure.

Done explicitly quitting the RunLoop when receiving the Detection().
(Here and in the other location).

[mcasas, 2017-02-13 15:27:40]

ping lads

[Robert Sesek, 2017-02-13 16:25:53]

lgtm

[Ken Rockot(use gerrit already), 2017-02-13 16:28:53]

services in general lgtm

[mcasas, 2017-02-13 16:36:27]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 16:36:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-02-13 16:40:51]

mcasas@chromium.org changed reviewers:
+ bajones@chromium.org

[mcasas, 2017-02-13 16:40:51]

kbr is OOO today -- bajones@ could you PTAL at the gpu json py file?

[Ken Russell (switch to Gerrit), 2017-02-13 17:07:48]

Good work. LGTM

[bajones, 2017-02-13 17:08:03]

On 2017/02/13 16:40:51, mcasas wrote:
> kbr is OOO today -- bajones@ could you PTAL at the gpu json py file?

LGTM

[mcasas, 2017-02-13 17:23:44]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2017-02-13 17:23:57]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-02-13 17:24:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 17:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 17:31:20]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mcasas, 2017-02-13 17:32:58]

mcasas@chromium.org changed reviewers:
+ bsalomon@chromium.org, erg@chromium.org

[mcasas, 2017-02-13 17:32:58]

bsalomon@, erg@
plz RS adding to DEPS:
    '+third_party/skia/include',
    '+ui/gfx/codec',
respectively, thanks!

[bsalomon, 2017-02-13 17:35:30]

bsalomon@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2017-02-13 17:35:30]

skia deps lgtm

[mcasas, 2017-02-13 17:55:19]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 17:56:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-02-13 18:21:08]

code deps lgtm in test

[mcasas, 2017-02-13 18:22:23]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 18:22:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-02-13 18:23:02]

Patchset #6 (id:260001) has been deleted

[mcasas, 2017-02-13 18:58:38]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2017-02-13 18:58:46]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-02-13 18:58:47]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
bajones@chromium.org, kbr@chromium.org, bsalomon@google.com,
rsesek@chromium.org, erg@chromium.org
Link to the patchset: https://codereview.chromium.org/2677553003/#ps280001
(title: "filter FaceDetectionImplMacTest")

[commit-bot: I haz the power, 2017-02-13 18:58:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 20:14:29]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1487012326873690,
"parent_rev": "1ffa882da6a9795878cbdd6bba4542d0158298a9", "commit_rev":
"3764134e53831644d51c780f3d9b3a50f8d43865"}

[commit-bot: I haz the power, 2017-02-13 20:15:03]

Description was changed from

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
service_unittests.  These new tests are run in the gpu bots, bc 
the normal Mac bots don't have GPUs and that seems to screw 
the CoreImage library (FTR I tried loading the lib and symbols in 
runtime and/or using a software rendering context, see PS2, but 
that didn't solve the problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Shape detection unittests mac (QR and Face) in GPU bots

This CL adds {Barcode,Face}Detection Mac unittests as part of 
service_unittests.  These new tests are run in the gpu bots, bc 
the normal Mac bots don't have GPUs and that seems to screw 
the CoreImage library (FTR I tried loading the lib and symbols in 
runtime and/or using a software rendering context, see PS2, but 
that didn't solve the problem).

BUG=665150, 659139
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2677553003
Cr-Commit-Position: refs/heads/master@{#450061}
Committed:
https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b...
==========

[commit-bot: I haz the power, 2017-02-13 20:15:04]

Committed patchset #6 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/3764134e53831644d51c780f3d9b...

[Garrett Casto, 2017-02-13 21:22:27]

A revert of this CL (patchset #6 id:280001) has been created in
https://codereview.chromium.org/2692123002/ by gcasto@chromium.org.

The reason for reverting is: This causes a failure in service_unittest for Mac
10.10:
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests.

[findit-for-me, 2017-02-13 21:50:28]

FYI: Findit identified this CL at revision 450061 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[Ken Russell (switch to Gerrit), 2017-02-14 00:47:09]

On 2017/02/13 21:50:28, findit-for-me wrote:
> FYI: Findit identified this CL at revision 450061 as the culprit for
> failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Miguel: that's why I suggested adding these tests to a brand new target that
doesn't run on the regular Chromium test bots, but only on the GPU bots.