Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2692043004: [Typed OM] Output correct types from CSSKeywordValue for css-wide keywords (Closed)

Created:
3 years, 10 months ago by meade_UTC10
Modified:
3 years, 10 months ago
Reviewers:
shans, rjwright
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Output correct types from CSSKeywordValue for css-wide keywords Also, for list-valued properties, pass the css-wide keyword's CSSValue into the inline style directly instead of wrapping it in a CSSValueList, as that is invalid too. Previously, our tests didn't use an element that was in the document, and didn't force a style recalc, so this issue did not hit the DCHECK. BUG=691455, 545318 Review-Url: https://codereview.chromium.org/2692043004 Cr-Commit-Position: refs/heads/master@{#452691} Committed: https://chromium.googlesource.com/chromium/src/+/b2cef4230a879b622aa29eea20154960bd402f7b

Patch Set 1 #

Patch Set 2 : Fix tests to actually test the things, and don't crash #

Patch Set 3 : Remove debugging code; use getComputedStyle instead of offsetTop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/bottom.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/property-suite.js View 1 2 7 chunks +29 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp View 2 2 chunks +14 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
meade_UTC10
3 years, 10 months ago (2017-02-17 03:58:23 UTC) #5
meade_UTC10
3 years, 10 months ago (2017-02-21 21:32:28 UTC) #10
shans
lgtm
3 years, 10 months ago (2017-02-22 04:56:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692043004/40001
3 years, 10 months ago (2017-02-22 05:12:21 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/394905)
3 years, 10 months ago (2017-02-22 07:27:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692043004/40001
3 years, 10 months ago (2017-02-23 23:04:40 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 00:39:30 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b2cef4230a879b622aa29eea2015...

Powered by Google App Engine
This is Rietveld 408576698