Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp

Issue 2692043004: [Typed OM] Output correct types from CSSKeywordValue for css-wide keywords (Closed)
Patch Set: Remove debugging code; use getComputedStyle instead of offsetTop Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp b/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
index 1e8c28b361d1630284971799aba3e1126c80352d..edcc24f27a5ad1b347a3db02bbcf382fcdc0a92e 100644
--- a/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
@@ -30,13 +30,14 @@ const CSSValue* styleValueToCSSValue(CSSPropertyID propertyID,
const CSSValue* singleStyleValueAsCSSValue(CSSPropertyID propertyID,
const CSSStyleValue& styleValue) {
- if (!CSSPropertyMetadata::propertyIsRepeated(propertyID))
- return styleValueToCSSValue(propertyID, styleValue);
-
const CSSValue* cssValue = styleValueToCSSValue(propertyID, styleValue);
if (!cssValue)
return nullptr;
+ if (!CSSPropertyMetadata::propertyIsRepeated(propertyID) ||
+ cssValue->isCSSWideKeyword())
+ return cssValue;
+
// TODO(meade): Determine the correct separator for each property.
CSSValueList* valueList = CSSValueList::createSpaceSeparated();
valueList->append(*cssValue);
« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698