Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2692023004: ChromeOS OOBE: update strings after review. (Closed)

Created:
3 years, 10 months ago by Alexander Alekseev
Modified:
3 years, 10 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: update strings after review. This Cl updates three strings for OOBE Accessibility screen, ToS screen, and update screen. BUG=604119 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2692023004 Cr-Commit-Position: refs/heads/master@{#450324} Committed: https://chromium.googlesource.com/chromium/src/+/fb7be6dfdc206f3edd14cd46199526e22f9453c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_update.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Alexander Alekseev
Please review.
3 years, 10 months ago (2017-02-13 22:28:48 UTC) #3
achuithb
On 2017/02/13 22:28:48, Alexander Alekseev wrote: > Please review. I assume the strings were discussed ...
3 years, 10 months ago (2017-02-14 09:25:11 UTC) #8
Alexander Alekseev
On 2017/02/14 09:25:11, achuithb wrote: > On 2017/02/13 22:28:48, Alexander Alekseev wrote: > > Please ...
3 years, 10 months ago (2017-02-14 11:32:37 UTC) #9
Alexander Alekseev
3 years, 10 months ago (2017-02-14 11:32:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692023004/1
3 years, 10 months ago (2017-02-14 11:33:20 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 11:46:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb7be6dfdc206f3edd14cd461995...

Powered by Google App Engine
This is Rietveld 408576698