Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2691993005: Revert of Move touch slop suppression from LegacyTouchEventQueue to TouchEventManager (Closed)

Created:
3 years, 10 months ago by mustaq
Modified:
3 years, 10 months ago
Reviewers:
lanwei
CC:
chromium-reviews, caseq+blink_chromium.org, dtapuska+blinkwatch_chromium.org, devtools-reviews_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, lushnikov+blink_chromium.org, Navid Zolghadr, blink-reviews, apavlov+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert of Move touch slop suppression from LegacyTouchEventQueue to TouchEventManager (patchset #3 id:40001 of https://codereview.chromium.org/2680013009/ ) Reason for revert: NaCl problems: crbug.com/691310 Original issue's description: > Move touch slop suppression from LegacyTouchEventQueue to TouchEventManager > > *** This is a selected minimal part of the cherry-picked CL *** > > We do not want to suppress pointer events, but the current code suppresses touch events from browser side, so the pointer events are also suppressed. We move the slop region suppression code to TouchEventManager, so all the pointer moves will be dispatched. > > BUG=593061, 682144 > > Review-Url: https://codereview.chromium.org/2669663002 > Cr-Commit-Position: refs/heads/master@{#448773} > (cherry picked from commit 00f7089132148e96541a6a476a68809790048e81) > > R=mustaq@chromium.org > > Review-Url: https://codereview.chromium.org/2680013009 . > Cr-Commit-Position: refs/branch-heads/2987@{#424} > Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} > Committed: https://chromium.googlesource.com/chromium/src/+/3a7825120516721b47e220d4075945834e78401f TBR=lanwei@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=682144, 691310 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2691993005 Cr-Commit-Position: refs/branch-heads/2987@{#510} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/a7ba9c6e69b1b9dd7747486c699496d90f48b62f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -77 lines) Patch
M content/browser/renderer_host/input/touch_event_queue.cc View 1 chunk +26 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 3 chunks +125 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.cpp View 3 chunks +0 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
mustaq
Created Revert of Move touch slop suppression from LegacyTouchEventQueue to TouchEventManager
3 years, 10 months ago (2017-02-14 21:30:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691993005/1
3 years, 10 months ago (2017-02-14 21:31:18 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-14 21:31:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691993005/1
3 years, 10 months ago (2017-02-14 21:38:19 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-14 21:38:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691993005/1
3 years, 10 months ago (2017-02-14 21:41:53 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 21:43:57 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7ba9c6e69b1b9dd7747486c6994...

Powered by Google App Engine
This is Rietveld 408576698