Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2680013009: Move touch slop suppression from LegacyTouchEventQueue to TouchEventManager (Closed)

Created:
3 years, 10 months ago by lanwei
Modified:
3 years, 10 months ago
Reviewers:
mustaq
CC:
chromium-reviews, caseq+blink_chromium.org, dtapuska+blinkwatch_chromium.org, devtools-reviews_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, lushnikov+blink_chromium.org, Navid Zolghadr, blink-reviews, apavlov+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Move touch slop suppression from LegacyTouchEventQueue to TouchEventManager *** This is a selected minimal part of the cherry-picked CL *** We do not want to suppress pointer events, but the current code suppresses touch events from browser side, so the pointer events are also suppressed. We move the slop region suppression code to TouchEventManager, so all the pointer moves will be dispatched. BUG=593061, 682144 Review-Url: https://codereview.chromium.org/2669663002 Cr-Commit-Position: refs/heads/master@{#448773} (cherry picked from commit 00f7089132148e96541a6a476a68809790048e81) R=mustaq@chromium.org Review-Url: https://codereview.chromium.org/2680013009 . Cr-Commit-Position: refs/branch-heads/2987@{#424} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/3a7825120516721b47e220d4075945834e78401f

Patch Set 1 #

Patch Set 2 : slop region #

Total comments: 1

Patch Set 3 : slop region #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -140 lines) Patch
M content/browser/renderer_host/input/touch_event_queue.cc View 1 2 1 chunk +2 lines, -26 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 3 chunks +32 lines, -114 lines 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.cpp View 1 3 chunks +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
mustaq
LGTM. https://codereview.chromium.org/2680013009/diff/20001/content/browser/renderer_host/input/touch_event_queue.cc File content/browser/renderer_host/input/touch_event_queue.cc (right): https://codereview.chromium.org/2680013009/diff/20001/content/browser/renderer_host/input/touch_event_queue.cc#newcode295 content/browser/renderer_host/input/touch_event_queue.cc:295: return false; Please remove the rest of the ...
3 years, 10 months ago (2017-02-09 22:00:05 UTC) #4
lanwei
Committed patchset #3 (id:40001) manually as 3a7825120516721b47e220d4075945834e78401f.
3 years, 10 months ago (2017-02-10 00:12:21 UTC) #6
mustaq
3 years, 10 months ago (2017-02-14 21:30:47 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2691993005/ by mustaq@chromium.org.

The reason for reverting is: NaCl problems: crbug.com/691310.

Powered by Google App Engine
This is Rietveld 408576698