Avoid mutating the NonInterpolableValue in CSSTextIndentInterpolationType::maybeMergeSingles()

Avoid mutating the NonInterpolableValue in CSSTextIndentInterpolationType::maybeMergeSingles()

This patch fixes test failures in https://codereview.chromium.org/2680923005
caused by incorrect handling of NIVs in CSSTextIndentInterpolationType.
Though the inputs to maybeMergeSingles() are r value references the inner
contents are shared by other InterpolationValues cloned from the same
conversion. This patch updates it to not mutate the inner contents.

BUG=681424
Review-Url: https://codereview.chromium.org/2691983003
Cr-Commit-Position: refs/heads/master@{#450551}
Committed: https://chromium.googlesource.com/chromium/src/+/20557391eabfddda39e9dd2734af1c8197845430

[alancutter (OOO until 2018), 2017-02-14 06:28:59]

alancutter@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[Eric Willigers, 2017-02-14 06:31:50]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 06:32:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2017-02-14 06:37:00]

lgtm

[commit-bot: I haz the power, 2017-02-14 12:32:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 12:32:47]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[alancutter (OOO until 2018), 2017-02-15 00:05:06]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-02-15 00:05:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 01:46:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487117106371030, "parent_rev":
"0ded2254448f22310ab52645b57a864b281c948d", "commit_rev":
"20557391eabfddda39e9dd2734af1c8197845430"}

[commit-bot: I haz the power, 2017-02-15 01:47:15]

Description was changed from

==========
Avoid mutating the NonInterpolableValue in
CSSTextIndentInterpolationType::maybeMergeSingles()

This patch fixes test failures in https://codereview.chromium.org/2680923005
caused by incorrect handling of NIVs in CSSTextIndentInterpolationType.
Though the inputs to maybeMergeSingles() are r value references the inner
contents are shared by other InterpolationValues cloned from the same
conversion. This patch updates it to not mutate the inner contents.

BUG=681424
==========

to

==========
Avoid mutating the NonInterpolableValue in
CSSTextIndentInterpolationType::maybeMergeSingles()

This patch fixes test failures in https://codereview.chromium.org/2680923005
caused by incorrect handling of NIVs in CSSTextIndentInterpolationType.
Though the inputs to maybeMergeSingles() are r value references the inner
contents are shared by other InterpolationValues cloned from the same
conversion. This patch updates it to not mutate the inner contents.

BUG=681424

Review-Url: https://codereview.chromium.org/2691983003
Cr-Commit-Position: refs/heads/master@{#450551}
Committed:
https://chromium.googlesource.com/chromium/src/+/20557391eabfddda39e9dd2734af...
==========

[commit-bot: I haz the power, 2017-02-15 01:47:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20557391eabfddda39e9dd2734af...