Avoid cyclic dependency FaviconHandler<-->FaviconDriverImpl

chrome/browser/sessions/session_restore_delegate.cc

Index: chrome/browser/sessions/session_restore_delegate.cc
diff --git a/chrome/browser/sessions/session_restore_delegate.cc b/chrome/browser/sessions/session_restore_delegate.cc
index f562d944ff296405d9484b1807926f66a1bed211..885d8ddf20e9d78c5e964b2879474ab5c7793225 100644
--- a/chrome/browser/sessions/session_restore_delegate.cc
+++ b/chrome/browser/sessions/session_restore_delegate.cc
@@ -76,6 +76,8 @@ void SessionRestoreDelegate::RestoreTabs(
     // Restore the favicon for deferred tabs.
     favicon::ContentFaviconDriver* favicon_driver =
         favicon::ContentFaviconDriver::FromWebContents(restored_tab.contents());
+    // TODO(mastiz): This seems broken: one call cancels previous ones so this
+    // is unlikely to do any good.

[pkotwicz, 2017/02/22 02:37:53]

This seems like this should be a crbug not a comment in the code

[mastiz, 2017/02/23 21:55:53]

Reverted, this was simply to raise awareness or get your thoughts on whether my
concern was legit.

     favicon_driver->FetchFavicon(favicon_driver->GetActiveURL());
   }