Avoid cyclic dependency FaviconHandler<-->FaviconDriverImpl

chrome/browser/sessions/session_restore_delegate.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sessions/session_restore_delegate.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/macros.h"
@@ skipping 58 matching lines @@
 void SessionRestoreDelegate::RestoreTabs(
     const std::vector<RestoredTab>& tabs,
     const base::TimeTicks& restore_started) {
   // Restore the favicon for all tabs. Any tab may end up being deferred due
   // to memory pressure so it's best to have some visual indication of its
   // contents.
   for (const auto& restored_tab : tabs) {
     // Restore the favicon for deferred tabs.
     favicon::ContentFaviconDriver* favicon_driver =
         favicon::ContentFaviconDriver::FromWebContents(restored_tab.contents());
+    // TODO(mastiz): This seems broken: one call cancels previous ones so this
+    // is unlikely to do any good.

[pkotwicz, 2017/02/22 02:37:53]

This seems like this should be a crbug not a comment in the code

[mastiz, 2017/02/23 21:55:53]

Reverted, this was simply to raise awareness or get your thoughts on whether my
concern was legit.

     favicon_driver->FetchFavicon(favicon_driver->GetActiveURL());
   }
 
   TabLoader::RestoreTabs(tabs, restore_started);
 }