Avoid cyclic dependency FaviconHandler<-->FaviconDriverImpl

chrome/browser/sessions/tab_loader.cc

Index: chrome/browser/sessions/tab_loader.cc
diff --git a/chrome/browser/sessions/tab_loader.cc b/chrome/browser/sessions/tab_loader.cc
index ef4c3cdeb8b3102d9f7d85ec609fa0fefffc4911..fb91c8fbb98368d9a981e415e04b41a327ff2032 100644
--- a/chrome/browser/sessions/tab_loader.cc
+++ b/chrome/browser/sessions/tab_loader.cc
@@ -114,6 +114,8 @@ void TabLoader::StartLoading(const std::vector<RestoredTab>& tabs) {
       favicon::ContentFaviconDriver* favicon_driver =
           favicon::ContentFaviconDriver::FromWebContents(
               restored_tab.contents());
+      // TODO(mastiz): This seems broken: one call cancels previous ones so this
+      // is unlikely to do any good.

[pkotwicz, 2017/02/22 02:37:53]

This seems like this should be a crbug not a comment in the code

[mastiz, 2017/02/23 21:55:53]

Ditto.

       // |favicon_driver| might be null when testing.
       if (favicon_driver)
         favicon_driver->FetchFavicon(favicon_driver->GetActiveURL());