Introduce computePositionForNodeRemoval() as replacement of updatePositionForNodeRemoval()

Introduce computePositionForNodeRemoval() as replacement of updatePositionForNodeRemoval()

This patch Introduces |computePositionForNodeRemoval()| as replacement of
|updatePositionForNodeRemoval()| to avoid using side-effect function to align
with other parts of code for improving code health.

BUG=695776
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2691913002
Cr-Commit-Position: refs/heads/master@{#452818}
Committed: https://chromium.googlesource.com/chromium/src/+/48aff7a40b37530a9f0c63e7169fecab3bf685d1

[yosin_UTC9, 2017-02-13 07:45:47]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 07:46:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 09:29:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 09:29:27]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-02-24 07:33:23]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 07:33:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 08:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 08:03:50]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[yosin_UTC9, 2017-02-24 08:04:35]

Description was changed from

==========
2017-02-13T16:44:26

2017-02-13T16:44:19

BUG=
==========

to

==========
Introduce computePositionForNodeRemoval() as replacement of
updatePositionForNodeRemoval()

This patch Introduces |computePositionForNodeRemoval()| as replacement of
|updatePositionForNodeRemoval()| to avoid using side-effect function to align
with other parts of code for improving code health.

BUG=695776
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-24 09:07:08]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-02-24 09:07:09]

PTAL

It seems bots are in trouble due by infra issue.

[tkent, 2017-02-24 14:12:58]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-02-24 14:12:58]

lgtm

[commit-bot: I haz the power, 2017-02-24 14:13:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 14:18:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487945578255300,
"parent_rev": "ff06d6bb2507b7d412a0ccb283ed977c10023110", "commit_rev":
"48aff7a40b37530a9f0c63e7169fecab3bf685d1"}

[commit-bot: I haz the power, 2017-02-24 14:19:04]

Description was changed from

==========
Introduce computePositionForNodeRemoval() as replacement of
updatePositionForNodeRemoval()

This patch Introduces |computePositionForNodeRemoval()| as replacement of
|updatePositionForNodeRemoval()| to avoid using side-effect function to align
with other parts of code for improving code health.

BUG=695776
TEST=n/a; no behavior changes
==========

to

==========
Introduce computePositionForNodeRemoval() as replacement of
updatePositionForNodeRemoval()

This patch Introduces |computePositionForNodeRemoval()| as replacement of
|updatePositionForNodeRemoval()| to avoid using side-effect function to align
with other parts of code for improving code health.

BUG=695776
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2691913002
Cr-Commit-Position: refs/heads/master@{#452818}
Committed:
https://chromium.googlesource.com/chromium/src/+/48aff7a40b37530a9f0c63e7169f...
==========

[commit-bot: I haz the power, 2017-02-24 14:19:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/48aff7a40b37530a9f0c63e7169f...