Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionEditor.cpp

Issue 2691913002: Introduce computePositionForNodeRemoval() as replacement of updatePositionForNodeRemoval() (Closed)
Patch Set: 2017-02-24T16:31:47 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionEditor.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
index 04dd091529a2b9c54eef9bd033a1e70fef097f22..7d38c7e2e8c82850fc667062453d25067df8ec20 100644
--- a/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionEditor.cpp
@@ -191,15 +191,6 @@ void SelectionEditor::nodeChildrenWillBeRemoved(ContainerNode& container) {
markCacheDirty();
}
-static Position computePositionForNodeRemoval(const Position& position,
- Node& nodeToBeRemoved) {
- Position result = position;
- // TODO(yosin): We should rename |updatePositionForNodeRemoval()|
- // to |computePositionForNodeRemoval()| to avoid using output parameter.
- updatePositionForNodeRemoval(result, nodeToBeRemoved);
- return result;
-}
-
void SelectionEditor::nodeWillBeRemoved(Node& nodeToBeRemoved) {
if (m_selection.isNone())
return;

Powered by Google App Engine
This is Rietveld 408576698