Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2691893002: s390: use new mul instruction (Closed)

Created:
3 years, 10 months ago by john.yan
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -57 lines) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 2 chunks +44 lines, -28 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 1 chunk +30 lines, -22 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/s390/assembler-s390.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/s390/assembler-s390.cc View 3 chunks +16 lines, -1 line 0 comments Download
M src/s390/constants-s390.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/s390/disasm-s390.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 2 chunks +20 lines, -6 lines 0 comments Download
M src/s390/simulator-s390.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/s390/simulator-s390.cc View 4 chunks +31 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-s390.cc View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
john.yan
ptal
3 years, 10 months ago (2017-02-13 05:03:33 UTC) #1
JoranSiu
lgtm with a minor nit. https://codereview.chromium.org/2691893002/diff/1/src/full-codegen/s390/full-codegen-s390.cc File src/full-codegen/s390/full-codegen-s390.cc (right): https://codereview.chromium.org/2691893002/diff/1/src/full-codegen/s390/full-codegen-s390.cc#newcode1599 src/full-codegen/s390/full-codegen-s390.cc:1599: // the result are ...
3 years, 10 months ago (2017-02-13 14:43:56 UTC) #2
john.yan
On 2017/02/13 14:43:56, JoranSiu wrote: > lgtm with a minor nit. > > https://codereview.chromium.org/2691893002/diff/1/src/full-codegen/s390/full-codegen-s390.cc > ...
3 years, 10 months ago (2017-02-13 14:50:46 UTC) #3
Benedikt Meurer
Sure. LGTM!
3 years, 10 months ago (2017-02-13 17:41:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691893002/20001
3 years, 10 months ago (2017-02-13 17:54:23 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 18:50:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2dab40ccda08c6382ae69e5d51bbc1c5c4f...

Powered by Google App Engine
This is Rietveld 408576698