[Presentation API] Remove state transition from PresentationConnection::take()

[Presentation API] Remove state transition from PresentationConnection::take()

PresentationConnection should have initial state "connecting". Remove state transition from PresentationConnection::take() to fix web platform tests.

BUG=691313
Review-Url: https://codereview.chromium.org/2691773002
Cr-Commit-Position: refs/heads/master@{#450497}
Committed: https://chromium.googlesource.com/chromium/src/+/f7f8986f02c2f2acb3c3c9dbd21d606aaef189e0

[zhaobin, 2017-02-13 18:48:20]

zhaobin@chromium.org changed reviewers:
+ imcheng@chromium.org, mfoltz@chromium.org

[mark a. foltz, 2017-02-13 21:47:23]

What changes the state to "connecting" after this change?

Is there a layout test that would have caught this bug?

[zhaobin, 2017-02-13 23:56:24]

On 2017/02/13 21:47:23, mark a. foltz wrote:
> What changes the state to "connecting" after this change?
> 
> Is there a layout test that would have caught this bug?

Change to "connected" in ReceiverConnectionProxy and
BrowserPresentationConnectionProxy.

Updated presentation-start.html to verify that initial state is 'connnecting'.
Media router browser tests verify that connection state is changed to
'connected'.

[mark a. foltz, 2017-02-14 00:08:48]

lgtm

[zhaobin, 2017-02-14 00:44:41]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 00:45:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 02:34:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 02:34:19]

Dry run: This issue passed the CQ dry run.

[imcheng, 2017-02-14 22:09:43]

lgtm

[zhaobin, 2017-02-14 22:28:44]

The CQ bit was checked by zhaobin@chromium.org

[commit-bot: I haz the power, 2017-02-14 22:29:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 22:41:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487111324479240,
"parent_rev": "c02f2614dc7eb919b2cdb5b3b6cd5a54199e815f", "commit_rev":
"f7f8986f02c2f2acb3c3c9dbd21d606aaef189e0"}

[commit-bot: I haz the power, 2017-02-14 22:42:08]

Description was changed from

==========
[Presentation API] Remove state transition from PresentationConnection::take()

PresentationConnection should have initial state "connecting". Remove state
transition from PresentationConnection::take() to fix web platform tests.

BUG=691313
==========

to

==========
[Presentation API] Remove state transition from PresentationConnection::take()

PresentationConnection should have initial state "connecting". Remove state
transition from PresentationConnection::take() to fix web platform tests.

BUG=691313

Review-Url: https://codereview.chromium.org/2691773002
Cr-Commit-Position: refs/heads/master@{#450497}
Committed:
https://chromium.googlesource.com/chromium/src/+/f7f8986f02c2f2acb3c3c9dbd21d...
==========

[commit-bot: I haz the power, 2017-02-14 22:42:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f7f8986f02c2f2acb3c3c9dbd21d...