third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp - Issue 2691773002: [Presentation API] Remove state transition from PresentationConnection::take()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 2691773002: [Presentation API] Remove state transition from PresentationConnection::take() (Closed)

Patch Set: update layout test to check initial state of presentation connection Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

index 066f24a98e0235baa9b18fd619f94f9a4405db3a..8de73c9597708d1eab3610dcf2aebe3f174800d2 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

@@ -209,9 +209,6 @@ PresentationConnection* PresentationConnection::take(

createSameThreadTask(&PresentationConnection::dispatchEventAsync,

wrapPersistent(request), wrapPersistent(event)));

- // Fire onconnect event asynchronously, after onconnectionavailable.

- connection->didChangeState(WebPresentationConnectionState::Connected);

return connection;

}

« no previous file with comments | « third_party/WebKit/LayoutTests/presentation/presentation-start.html ('k') | no next file » | no next file with comments »