Remove OnCertDBChanged |cert| parameter.

Remove OnCertDBChanged |cert| parameter.

It would be null in most cases, so no consumers bothered to try to use it.

BUG=none

Review-Url: https://codereview.chromium.org/2691683003
Cr-Commit-Position: refs/heads/master@{#451425}
Committed: https://chromium.googlesource.com/chromium/src/+/fd05a1f546bbc0d6f11e4648cc7c961cb2ffac3f

[mattm, 2017-02-10 23:24:42]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 23:25:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-02-10 23:39:13]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 23:39:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-02-11 00:46:00]

Description was changed from

==========
Remove OnCertDBChanged |cert| parameter.

It would be null in most cases, so no consumers even tried to use it.

BUG=none
==========

to

==========
Remove OnCertDBChanged |cert| parameter.

It would be null in most cases, so no consumers bothered to try to use it.

BUG=none
==========

[mattm, 2017-02-11 00:48:05]

mattm@chromium.org changed reviewers:
+ svaldez@chromium.org

[commit-bot: I haz the power, 2017-02-11 01:35:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 01:35:02]

Dry run: This issue passed the CQ dry run.

[svaldez, 2017-02-13 15:59:40]

lgtm

https://codereview.chromium.org/2691683003/diff/20001/net/cert/nss_cert_datab...
File net/cert/nss_cert_database.h (right):

https://codereview.chromium.org/2691683003/diff/20001/net/cert/nss_cert_datab...
net/cert/nss_cert_database.h:44: // Will be called when a certificate is added,
removed, or changed trust
Wording seems a bit odd.

"or trust settings are changed"
or

"on change of trust settings"

[mattm, 2017-02-13 20:30:08]

mattm@chromium.org changed reviewers:
+ oshima@chromium.org

[mattm, 2017-02-13 20:30:09]

+oshima for chromeos/ OWNERS

https://codereview.chromium.org/2691683003/diff/20001/net/cert/nss_cert_datab...
File net/cert/nss_cert_database.h (right):

https://codereview.chromium.org/2691683003/diff/20001/net/cert/nss_cert_datab...
net/cert/nss_cert_database.h:44: // Will be called when a certificate is added,
removed, or changed trust
On 2017/02/13 15:59:40, svaldez wrote:
> Wording seems a bit odd.
> 
> "or trust settings are changed"
> or
> 
> "on change of trust settings"

Done.

[mattm, 2017-02-17 00:47:45]

ping oshima

[oshima, 2017-02-17 17:00:59]

chromeos lgtm

[mattm, 2017-02-17 20:17:05]

The CQ bit was checked by mattm@chromium.org

[mattm, 2017-02-17 20:17:06]

The patchset sent to the CQ was uploaded after l-g-t-m from svaldez@chromium.org
Link to the patchset: https://codereview.chromium.org/2691683003/#ps40001
(title: "comment wording")

[commit-bot: I haz the power, 2017-02-17 20:18:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 20:36:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:36:49]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[mattm, 2017-02-17 20:39:45]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:40:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 20:43:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:43:42]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[mattm, 2017-02-18 01:57:19]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:58:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 04:00:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 04:00:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[mattm, 2017-02-18 04:51:26]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-02-18 04:51:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 06:18:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487393486568160,
"parent_rev": "318b5ba71be0ccbf2bbc2f79d55af1d2b2d24f93", "commit_rev":
"fd05a1f546bbc0d6f11e4648cc7c961cb2ffac3f"}

[commit-bot: I haz the power, 2017-02-18 06:19:41]

Description was changed from

==========
Remove OnCertDBChanged |cert| parameter.

It would be null in most cases, so no consumers bothered to try to use it.

BUG=none
==========

to

==========
Remove OnCertDBChanged |cert| parameter.

It would be null in most cases, so no consumers bothered to try to use it.

BUG=none

Review-Url: https://codereview.chromium.org/2691683003
Cr-Commit-Position: refs/heads/master@{#451425}
Committed:
https://chromium.googlesource.com/chromium/src/+/fd05a1f546bbc0d6f11e4648cc7c...
==========

[commit-bot: I haz the power, 2017-02-18 06:19:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fd05a1f546bbc0d6f11e4648cc7c...