Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: net/cert/nss_cert_database.h

Issue 2691683003: Remove OnCertDBChanged |cert| parameter. (Closed)
Patch Set: comment wording Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/cert_database_mac.cc ('k') | net/cert/nss_cert_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/nss_cert_database.h
diff --git a/net/cert/nss_cert_database.h b/net/cert/nss_cert_database.h
index f52995e81de4a6de2c430aa07e85cbb6b4a680e8..d096f18d654ec9d1f48c08ad373a896c55b4d2b3 100644
--- a/net/cert/nss_cert_database.h
+++ b/net/cert/nss_cert_database.h
@@ -41,10 +41,9 @@ class NET_EXPORT NSSCertDatabase {
public:
virtual ~Observer() {}
- // Will be called when a CA certificate is changed.
- // Called with |cert| == NULL after importing a list of certificates
- // in ImportCACerts().
- virtual void OnCertDBChanged(const X509Certificate* cert) {}
+ // Will be called when a certificate is added, removed, or trust settings
+ // are changed.
+ virtual void OnCertDBChanged() {}
protected:
Observer() {}
@@ -246,7 +245,7 @@ class NET_EXPORT NSSCertDatabase {
protected:
// Broadcasts notifications to all registered observers.
- void NotifyObserversCertDBChanged(const X509Certificate* cert);
+ void NotifyObserversCertDBChanged();
private:
// Registers |observer| to receive notifications of certificate changes. The
@@ -261,10 +260,9 @@ class NET_EXPORT NSSCertDatabase {
// on the same thread on which AddObserver() was called.
void RemoveObserver(Observer* observer);
- // Notifies observers of the removal of |cert| and calls |callback| with
+ // Notifies observers of the removal of a cert and calls |callback| with
// |success| as argument.
- void NotifyCertRemovalAndCallBack(scoped_refptr<X509Certificate> cert,
- const DeleteCertCallback& callback,
+ void NotifyCertRemovalAndCallBack(const DeleteCertCallback& callback,
bool success);
// Certificate removal implementation used by |DeleteCertAndKey*|. Static so
« no previous file with comments | « net/cert/cert_database_mac.cc ('k') | net/cert/nss_cert_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698