media: Add UMA to record time to GenerateRequest and LoadSession

media: Add UMA to record time to GenerateRequest and LoadSession

This could help us monitor the performance of these two operations on
various key systems.

In the future, we could also report time spent on other operations
like UpdateSession() if needed.

BUG=690722
TEST=Manually tested and saw Media.EME.Widevine.TimeTo.GenerateRequest
in about://histograms

Review-Url: https://codereview.chromium.org/2691673002
Cr-Commit-Position: refs/heads/master@{#449853}
Committed: https://chromium.googlesource.com/chromium/src/+/6445a816eea59b22caa418e00be12f1ccf9be21c

[xhwang, 2017-02-10 22:05:22]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 22:05:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2017-02-10 22:07:01]

xhwang@chromium.org changed reviewers:
+ jrummell@chromium.org

[xhwang, 2017-02-10 22:07:02]

jrummell: PTAL
rkuroiwa / hmchen: FYI

[xhwang, 2017-02-10 22:08:23]

Description was changed from

==========
media: Add UMA to record time to GenerateRequest and LoadSession

This could help us monitor the performance of these two operations on
various key systems.

BUG=690722
TEST=Manually tested and saw Media.EME.Widevine.TimeTo.GenerateRequest
in about://histograms
==========

to

==========
media: Add UMA to record time to GenerateRequest and LoadSession

This could help us monitor the performance of these two operations on
various key systems.

In the future, we could also report time spent on other operations
like UpdateSession() if needed.

BUG=690722
TEST=Manually tested and saw Media.EME.Widevine.TimeTo.GenerateRequest
in about://histograms
==========

[commit-bot: I haz the power, 2017-02-10 23:49:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 23:49:20]

Dry run: This issue passed the CQ dry run.

[jrummell, 2017-02-11 00:39:17]

lgtm

[xhwang, 2017-02-11 00:45:47]

xhwang@chromium.org changed reviewers:
+ isherman@chromium.org

[xhwang, 2017-02-11 00:45:48]

isherman: Please OWNERS review from UMA's perspective.

[Ilya Sherman, 2017-02-11 00:50:54]

https://codereview.chromium.org/2691673002/diff/1/media/blink/cdm_result_prom...
File media/blink/cdm_result_promise_helper.cc (right):

https://codereview.chromium.org/2691673002/diff/1/media/blink/cdm_result_prom...
media/blink/cdm_result_promise_helper.cc:80: histogram->AddTime(time);
Please use "base::UmaHistogramTimes(name, time);" here.

[xhwang, 2017-02-11 01:11:14]

comments addressed

[xhwang, 2017-02-11 01:12:34]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[xhwang, 2017-02-11 01:12:45]

isherman: PTAL again!

https://codereview.chromium.org/2691673002/diff/1/media/blink/cdm_result_prom...
File media/blink/cdm_result_promise_helper.cc (right):

https://codereview.chromium.org/2691673002/diff/1/media/blink/cdm_result_prom...
media/blink/cdm_result_promise_helper.cc:80: histogram->AddTime(time);
On 2017/02/11 00:50:53, Ilya Sherman wrote:
> Please use "base::UmaHistogramTimes(name, time);" here.

Great. Didn't know this existed. PTAL again!

[commit-bot: I haz the power, 2017-02-11 01:13:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-02-11 01:23:41]

Metrics LGTM, thanks.

[xhwang, 2017-02-11 01:27:43]

The CQ bit was unchecked by xhwang@chromium.org

[xhwang, 2017-02-11 01:27:43]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2017-02-11 01:27:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
jrummell@chromium.org
Link to the patchset: https://codereview.chromium.org/2691673002/#ps20001
(title: "comments addressed")

[commit-bot: I haz the power, 2017-02-11 01:27:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 07:14:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 07:14:31]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[xhwang, 2017-02-11 08:02:33]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2017-02-11 08:02:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 09:36:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486800153791500,
"parent_rev": "0777b519e91b04d1531711270237181150933257", "commit_rev":
"6445a816eea59b22caa418e00be12f1ccf9be21c"}

[commit-bot: I haz the power, 2017-02-11 09:37:23]

Description was changed from

==========
media: Add UMA to record time to GenerateRequest and LoadSession

This could help us monitor the performance of these two operations on
various key systems.

In the future, we could also report time spent on other operations
like UpdateSession() if needed.

BUG=690722
TEST=Manually tested and saw Media.EME.Widevine.TimeTo.GenerateRequest
in about://histograms
==========

to

==========
media: Add UMA to record time to GenerateRequest and LoadSession

This could help us monitor the performance of these two operations on
various key systems.

In the future, we could also report time spent on other operations
like UpdateSession() if needed.

BUG=690722
TEST=Manually tested and saw Media.EME.Widevine.TimeTo.GenerateRequest
in about://histograms

Review-Url: https://codereview.chromium.org/2691673002
Cr-Commit-Position: refs/heads/master@{#449853}
Committed:
https://chromium.googlesource.com/chromium/src/+/6445a816eea59b22caa418e00be1...
==========

[commit-bot: I haz the power, 2017-02-11 09:37:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6445a816eea59b22caa418e00be1...