Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: media/blink/new_session_cdm_result_promise.cc

Issue 2691673002: media: Add UMA to record time to GenerateRequest and LoadSession (Closed)
Patch Set: comments addressed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/new_session_cdm_result_promise.h ('k') | media/blink/webcontentdecryptionmodulesession_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/new_session_cdm_result_promise.cc
diff --git a/media/blink/new_session_cdm_result_promise.cc b/media/blink/new_session_cdm_result_promise.cc
index 2f37a3e3da840c0ad9c2b6f6c75618210943dc81..3536454991f905a2b3bf892abaad590af1162f8f 100644
--- a/media/blink/new_session_cdm_result_promise.cc
+++ b/media/blink/new_session_cdm_result_promise.cc
@@ -5,11 +5,14 @@
#include "media/blink/new_session_cdm_result_promise.h"
#include "base/logging.h"
+#include "base/metrics/histogram_functions.h"
#include "media/blink/cdm_result_promise_helper.h"
#include "third_party/WebKit/public/platform/WebString.h"
namespace media {
+const char kTimeUMAPrefix[] = "TimeTo.";
+
static blink::WebContentDecryptionModuleResult::SessionStatus ConvertStatus(
SessionInitStatus status) {
switch (status) {
@@ -28,12 +31,14 @@ static blink::WebContentDecryptionModuleResult::SessionStatus ConvertStatus(
NewSessionCdmResultPromise::NewSessionCdmResultPromise(
const blink::WebContentDecryptionModuleResult& result,
+ const std::string& key_system_uma_prefix,
const std::string& uma_name,
const SessionInitializedCB& new_session_created_cb)
: web_cdm_result_(result),
+ key_system_uma_prefix_(key_system_uma_prefix),
uma_name_(uma_name),
- new_session_created_cb_(new_session_created_cb) {
-}
+ new_session_created_cb_(new_session_created_cb),
+ creation_time_(base::TimeTicks::Now()) {}
NewSessionCdmResultPromise::~NewSessionCdmResultPromise() {
if (!IsPromiseSettled())
@@ -52,7 +57,12 @@ void NewSessionCdmResultPromise::resolve(const std::string& session_id) {
}
MarkPromiseSettled();
- ReportCdmResultUMA(uma_name_, SUCCESS);
+ ReportCdmResultUMA(key_system_uma_prefix_ + uma_name_, SUCCESS);
+
+ // Only report time for promise resolution (not rejection).
+ base::UmaHistogramTimes(key_system_uma_prefix_ + kTimeUMAPrefix + uma_name_,
+ base::TimeTicks::Now() - creation_time_);
+
web_cdm_result_.completeWithSession(ConvertStatus(status));
}
« no previous file with comments | « media/blink/new_session_cdm_result_promise.h ('k') | media/blink/webcontentdecryptionmodulesession_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698