Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 2691653003: Compute bounds of type variables. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -13 lines) Patch
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 4 chunks +23 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_type_variable_builder.dart View 4 chunks +6 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/outline.status View 1 chunk +0 lines, -3 lines 1 comment Download
M pkg/front_end/test/fasta/rasta/issue_000067.dart.outline.expect View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000070.dart.outline.expect View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
https://codereview.chromium.org/2691653003/diff/1/pkg/front_end/test/fasta/outline.status File pkg/front_end/test/fasta/outline.status (right): https://codereview.chromium.org/2691653003/diff/1/pkg/front_end/test/fasta/outline.status#newcode14 pkg/front_end/test/fasta/outline.status:14: rasta/issue_000067: Fail Still failing this as I generate "dynamic" ...
3 years, 10 months ago (2017-02-10 21:28:38 UTC) #2
Johnni Winther
lgtm
3 years, 10 months ago (2017-02-13 13:29:27 UTC) #3
ahe
3 years, 10 months ago (2017-02-13 15:22:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a9caa23967d3a279845cea1d7215be91aaa9fc6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698