Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2682333004: Remove convertConstructors. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Long line. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -161 lines) Patch
M pkg/front_end/lib/src/fasta/builder/builder.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/type_variable_builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 1 9 chunks +59 lines, -13 lines 2 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart View 3 chunks +0 lines, -59 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_class_builder.dart View 6 chunks +17 lines, -53 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 7 chunks +31 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/enum.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/enum.dart.dartk.expect View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/enum.dart.direct.expect View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/enum.dart.outline.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000067.dart.direct.expect View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000070.dart.direct.expect View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 2695453002 Patch 1

Dependent Patchsets:

Issue 2691653003 Patch 1

Messages

Total messages: 7 (3 generated)
ahe
3 years, 10 months ago (2017-02-10 21:02:17 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/2682333004/diff/40001/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart File pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart (right): https://codereview.chromium.org/2682333004/diff/40001/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart#newcode311 pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart:311: var newVariable = new KernelTypeVariableBuilder( Add directly to ...
3 years, 10 months ago (2017-02-13 09:50:35 UTC) #4
ahe
Thank you, Johnni! https://codereview.chromium.org/2682333004/diff/40001/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart File pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart (right): https://codereview.chromium.org/2682333004/diff/40001/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart#newcode311 pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart:311: var newVariable = new KernelTypeVariableBuilder( On ...
3 years, 10 months ago (2017-02-13 14:58:53 UTC) #5
ahe
3 years, 10 months ago (2017-02-13 15:14:36 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
261ecfab5c5a2355e0b4f05af31f978405d366c9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698