Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2691953002: Fix crash in DillClassBuilder.isAbstract. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M pkg/front_end/lib/src/fasta/dill/dill_class_builder.dart View 3 chunks +9 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
ahe
3 years, 10 months ago (2017-02-13 10:07:52 UTC) #2
Johnni Winther
lgtm
3 years, 10 months ago (2017-02-13 13:30:32 UTC) #3
Johnni Winther
lgtm lgtm
3 years, 10 months ago (2017-02-13 13:30:32 UTC) #4
Johnni Winther
spaceship, spaceship!, SPACESHIP!!
3 years, 10 months ago (2017-02-13 13:31:08 UTC) #5
ahe
Committed patchset #1 (id:1) manually as be36f83e5caf5ed1fbc9b949e4ede87f185f279a (presubmit successful).
3 years, 10 months ago (2017-02-13 15:25:02 UTC) #7
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-02-14 22:54:29 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698