Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2691543003: Revert of Re-enable SecurityTest.NewOverFlow on Windows. (Closed)

Created:
3 years, 10 months ago by Nico
Modified:
3 years, 10 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable SecurityTest.NewOverFlow on Windows. (patchset #2 id:40001 of https://codereview.chromium.org/2679153002/ ) Reason for revert: Broke all the clang/win bots (https://crbug.com/690271), and I'd like to have them clear for the weekend. Easy to reland. Original issue's description: > Re-enable SecurityTest.NewOverFlow on Windows. > > BUG= > > Review-Url: https://codereview.chromium.org/2679153002 > Cr-Commit-Position: refs/heads/master@{#449041} > Committed: https://chromium.googlesource.com/chromium/src/+/82681d8ead6aa059caf6a64e485dbc6b210339be TBR=wfh@chromium.org,gab@chromium.org,siggi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2691543003 Cr-Commit-Position: refs/heads/master@{#449778} Committed: https://chromium.googlesource.com/chromium/src/+/4f46a461e16b504b1b2105a8b717be39bd688c02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M base/security_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Nico
Created Revert of Re-enable SecurityTest.NewOverFlow on Windows.
3 years, 10 months ago (2017-02-10 22:57:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691543003/1
3 years, 10 months ago (2017-02-10 22:57:57 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 23:14:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f46a461e16b504b1b2105a8b717...

Powered by Google App Engine
This is Rietveld 408576698