Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2691363005: Mojo C++ bindings: remove usage of AssociatedGroup from blink. (Closed)

Created:
3 years, 10 months ago by yzshen1
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: remove usage of AssociatedGroup from blink. This class is now supposed to be used in mojo-bindings-internal code. Users don't have to know about it. BUG=682334 Review-Url: https://codereview.chromium.org/2691363005 Cr-Commit-Position: refs/heads/master@{#451001} Committed: https://chromium.googlesource.com/chromium/src/+/61f516e73a93be7af99a1176e07a04d00646dfe5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp View 1 chunk +2 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (12 generated)
yzshen1
Hi, Kentaro. Would you please take a look? Thanks!
3 years, 10 months ago (2017-02-15 21:14:02 UTC) #3
haraken
LGTM
3 years, 10 months ago (2017-02-16 00:22:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691363005/1
3 years, 10 months ago (2017-02-16 00:35:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/120036)
3 years, 10 months ago (2017-02-16 02:06:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691363005/1
3 years, 10 months ago (2017-02-16 03:01:31 UTC) #13
commit-bot: I haz the power
Exceeded global retry quota
3 years, 10 months ago (2017-02-16 05:35:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691363005/1
3 years, 10 months ago (2017-02-16 16:44:38 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 17:21:59 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/61f516e73a93be7af99a1176e07a...

Powered by Google App Engine
This is Rietveld 408576698