Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2691333002: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] (Closed)

Created:
3 years, 10 months ago by riju_
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, kinuko+worker_chromium.org, jsbell+serviceworker_chromium.org, serviceworker-reviews, shimazu+serviceworker_chromium.org, sof, eae+blinkwatch, kinuko+serviceworker, nhiroki, shimazu+worker_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, michaeln, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik, blink-worker-reviews_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] in serviceworker. BUG=670618 Review-Url: https://codereview.chromium.org/2691333002 Cr-Commit-Position: refs/heads/master@{#450665} Committed: https://chromium.googlesource.com/chromium/src/+/3809b56129eb99b2e600bf20a876745a1fd8cc18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -40 lines) Patch
M third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/MessagePort.cpp View 4 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/Client.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/InstallEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/InstallEvent.cpp View 3 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/InstallEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp View 4 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
riju_
haraken@ : PTAL.
3 years, 10 months ago (2017-02-15 10:39:07 UTC) #6
haraken
LGTM
3 years, 10 months ago (2017-02-15 11:12:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691333002/1
3 years, 10 months ago (2017-02-15 11:19:46 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 11:24:21 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3809b56129eb99b2e600bf20a876...

Powered by Google App Engine
This is Rietveld 408576698