third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp - Issue 2691333002: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

Issue 2691333002: Replace [CallWith=ExecutionContext] with [CallWith=ScriptState] (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

index d84143475422e960eef604e4b433909262e1961f..a8acb3641b26bfe3c172a1eeef558c9b8b8a7361 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp

@@ -5,6 +5,7 @@

#include "modules/serviceworkers/ServiceWorkerLinkResource.h"

#include "bindings/core/v8/ExceptionState.h"

+#include "bindings/core/v8/ScriptState.h"

#include "core/dom/Document.h"

#include "core/frame/DOMWindow.h"

#include "core/frame/LocalFrame.h"

@@ -81,7 +82,8 @@ void ServiceWorkerLinkResource::process() {

String errorMessage;

ServiceWorkerContainer* container = NavigatorServiceWorker::serviceWorker(

- &document, *document.frame()->domWindow()->navigator(), errorMessage);

+ ScriptState::forMainWorld(m_owner->document().frame()),

+ *document.frame()->domWindow()->navigator(), errorMessage);

if (!container) {

document.addConsoleMessage(ConsoleMessage::create(

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp ('k') | no next file » | no next file with comments »