Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2691163003: Fix handling of malformed surrogate pairs for break-all (Closed)

Created:
3 years, 10 months ago by eae
Modified:
3 years, 10 months ago
Reviewers:
cbiesinger
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix handling of malformed surrogate pairs for break-all BUG=690218 R=cbiesinger@chromium.org Review-Url: https://codereview.chromium.org/2691163003 Cr-Commit-Position: refs/heads/master@{#450496} Committed: https://chromium.googlesource.com/chromium/src/+/c02f2614dc7eb919b2cdb5b3b6cd5a54199e815f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextRunConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
cbiesinger
lgtm
3 years, 10 months ago (2017-02-14 19:01:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691163003/1
3 years, 10 months ago (2017-02-14 19:02:57 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 22:37:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c02f2614dc7eb919b2cdb5b3b6cd...

Powered by Google App Engine
This is Rietveld 408576698