Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: third_party/WebKit/Source/core/layout/TextRunConstructor.cpp

Issue 2691163003: Fix handling of malformed surrogate pairs for break-all (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutText.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/TextRunConstructor.cpp
diff --git a/third_party/WebKit/Source/core/layout/TextRunConstructor.cpp b/third_party/WebKit/Source/core/layout/TextRunConstructor.cpp
index f7707d47ed336329970b7ac4571fe6444006ddcd..c0ed240d27668c448e241241bedbadf20d6ad1d6 100644
--- a/third_party/WebKit/Source/core/layout/TextRunConstructor.cpp
+++ b/third_party/WebKit/Source/core/layout/TextRunConstructor.cpp
@@ -139,7 +139,7 @@ TextRun constructTextRun(const Font& font,
unsigned offset,
unsigned length,
const ComputedStyle& style) {
- ASSERT(offset + length <= text.textLength());
+ SECURITY_DCHECK(offset + length <= text.textLength());
if (text.hasEmptyText()) {
return constructTextRunInternal(font, static_cast<const LChar*>(nullptr), 0,
style, TextDirection::kLtr);
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutText.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698