Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1792)

Issue 2691083002: [DevTools] Allow bundled DevTools for Node targets (Closed)

Created:
3 years, 10 months ago by eostroukhov
Modified:
3 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[DevTools] Allow bundled DevTools for Node targets BUG=691022 Review-Url: https://codereview.chromium.org/2693493003 Cr-Commit-Position: refs/heads/master@{#449699} (cherry picked from commit 41332227e15f05ae9dcbfe1ef6297d041cfc1b9a) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2691083002 Cr-Commit-Position: refs/branch-heads/2987@{#481} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/4449f5ac231319e6a27b2a7aa6aa7190c944d4bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/webui/devtools_ui.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
eostroukhov
This is a merge commit. I don't think I can land it without approval.
3 years, 10 months ago (2017-02-13 19:01:49 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-02-13 19:07:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691083002/1
3 years, 10 months ago (2017-02-13 19:09:08 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-13 19:09:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691083002/1
3 years, 10 months ago (2017-02-13 19:13:19 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 19:15:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4449f5ac231319e6a27b2a7aa6aa...

Powered by Google App Engine
This is Rietveld 408576698