Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2693493003: [DevTools] Allow bundled DevTools for Node targets (Closed)

Created:
3 years, 10 months ago by eostroukhov
Modified:
3 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Allow bundled DevTools for Node targets BUG=691022 Review-Url: https://codereview.chromium.org/2693493003 Cr-Commit-Position: refs/heads/master@{#449699} Committed: https://chromium.googlesource.com/chromium/src/+/41332227e15f05ae9dcbfe1ef6297d041cfc1b9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/webui/devtools_ui.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
eostroukhov
Please take a look
3 years, 10 months ago (2017-02-10 18:57:16 UTC) #3
pfeldman
lgtm
3 years, 10 months ago (2017-02-10 19:17:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693493003/1
3 years, 10 months ago (2017-02-10 19:20:35 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 19:46:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/41332227e15f05ae9dcbfe1ef629...

Powered by Google App Engine
This is Rietveld 408576698